Skip to content

Commit 97ca9ab

Browse files
Renamed Timeline 'pump' method to 'builder' because its not actually a pumper
1 parent 41560f1 commit 97ca9ab

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

lib/src/scenes/timeline.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ class Timeline {
5757
/// Setup the scene before taking any photos.
5858
///
5959
/// If you only need to provide a widget tree, without taking other [WidgetTester]
60-
/// actions, consider using [setupWithPump] for convenience.
60+
/// actions, consider using [setupWithBuilder] for convenience.
6161
Timeline setup(TimelineSetupDelegate delegate) {
6262
if (_setup != null) {
6363
throw Exception("Timeline was already set up, but tried to call setup() again.");
@@ -72,10 +72,10 @@ class Timeline {
7272
return this;
7373
}
7474

75-
/// Setup the scene before taking any photos, by pumping a widget tree.
75+
/// Setup the scene before taking any photos, by building a widget tree.
7676
///
77-
/// If you need to take additional actions, beyond a single pump, use [setup] instead.
78-
Timeline setupWithPump(TimelineSetupWithPumpFactory sceneBuilder) {
77+
/// If you need to take additional actions, beyond a builder delegate, use [setup] instead.
78+
Timeline setupWithBuilder(TimelineSetupBuilder sceneBuilder) {
7979
if (_setup != null) {
8080
throw Exception("Timeline was already set up, but tried to call setupWithPump() again.");
8181
}
@@ -565,7 +565,7 @@ class _TimelineSetup {
565565

566566
typedef TimelineSetupDelegate = Future<void> Function(WidgetTester tester);
567567

568-
typedef TimelineSetupWithPumpFactory = Widget Function();
568+
typedef TimelineSetupBuilder = Widget Function();
569569

570570
class _TimelinePhotoRequest {
571571
const _TimelinePhotoRequest(this.photoBoundsFinder, this.description);

test_goldens/flutter/buttons/buttons_test.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ void main() {
1414
fileName: "button_elevated_interactions",
1515
layout: RowSceneLayout(),
1616
)
17-
.setupWithPump(() {
17+
.setupWithBuilder(() {
1818
return FlutterWidgetScaffold(
1919
goldenKey: goldenKey,
2020
child: ElevatedButton(
@@ -39,7 +39,7 @@ void main() {
3939
fileName: "button_text_interactions",
4040
layout: RowSceneLayout(),
4141
)
42-
.setupWithPump(() {
42+
.setupWithBuilder(() {
4343
return FlutterWidgetScaffold(
4444
goldenKey: goldenKey,
4545
child: TextButton(
@@ -64,7 +64,7 @@ void main() {
6464
fileName: "button_icon_interactions",
6565
layout: RowSceneLayout(),
6666
)
67-
.setupWithPump(() {
67+
.setupWithBuilder(() {
6868
return MaterialApp(
6969
theme: ThemeData(
7070
fontFamily: goldenBricks,
@@ -98,7 +98,7 @@ void main() {
9898
fileName: "button_fab_interactions",
9999
layout: RowSceneLayout(),
100100
)
101-
.setupWithPump(() {
101+
.setupWithBuilder(() {
102102
return FlutterWidgetScaffold(
103103
goldenKey: goldenKey,
104104
child: FloatingActionButton(
@@ -130,7 +130,7 @@ void main() {
130130
),
131131
),
132132
)
133-
.setupWithPump(() {
133+
.setupWithBuilder(() {
134134
return FlutterWidgetScaffold(
135135
goldenKey: goldenKey,
136136
child: FloatingActionButton.extended(

test_goldens/flutter/list_tile/list_tile_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ void main() {
1515
fileName: "list_tile_interactions",
1616
layout: ColumnSceneLayout(),
1717
)
18-
.setupWithPump(() {
18+
.setupWithBuilder(() {
1919
return FlutterWidgetScaffold(
2020
goldenKey: goldenKey,
2121
child: SizedBox(

test_goldens/flutter/textfield/textfield_tests.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ void main() {
1313
fileName: "textfield_interactions",
1414
layout: ColumnSceneLayout(),
1515
)
16-
.setupWithPump(() {
16+
.setupWithBuilder(() {
1717
return FlutterWidgetScaffold(
1818
goldenKey: goldenKey,
1919
child: SizedBox(

0 commit comments

Comments
 (0)