Adjusted how we send the kill command through Process, also removed a couple workflow steps that may have killed the simulator

Author: matthew-carroll

.github/workflows/pr_validation.yaml

@@ -236,11 +236,11 @@ jobs:
           echo "Checking for app's container on the booted simulator:"
           xcrun simctl get_app_container booted com.flutterbountyhunters.deeplinks.example
 
-      - name: Kill any simctl processes
-        run: pkill -f runner
-
-      - name: Check for other processes using the simulator
-        run: ps aux | grep simctl
+#      - name: Kill any simctl processes
+#        run: pkill -f runner
+#
+#      - name: Check for other processes using the simulator
+#        run: ps aux | grep simctl
 
       #      - name: Launch the app on the simulator just to prove we can
 #        run: |

packages/flutter_test_runners/lib/src/platform_comms/ios/xcrun.dart

@@ -130,7 +130,7 @@ class Xcrun {
     print("Sending xcrun simctl terminate command...");
     final process = await Process.start(
       "sh",
-      ["-c", "xcrun", "simctl", "terminate", "booted", appBundleId],
+      ["-c", "xcrun simctl terminate booted $appBundleId"],
     );
     print("terminate command process was started");
 
@@ -167,9 +167,12 @@ class Xcrun {
     // );
   }
 
-  static Future<ProcessResult> _runInShell(List<String> commandAndArgs) {
+  static Future<ProcessResult> _runInShell(List<String> commandAndArgs) async {
     print("Sending shell command: '${commandAndArgs.join(" ")}'");
-    return Process.run("sh", ["-c", ...commandAndArgs]);
+    final result = await Process.run("sh", ["-c", ...commandAndArgs]);
+    print("Shell command exit code: ${result.exitCode}");
+    return result;
+
     // return Process.run(
     //   commandAndArgs.first,
     //   commandAndArgs.length > 1 ? commandAndArgs.sublist(1) : [],