Assure TextNodePosition is only used on pasted TextNodes when pasting single-node content; slight reformatting to repo standard line length; learnt about selectionEquivalentTo matcher.

Author: JostSchenck

super_editor/lib/src/default_editor/common_editor_operations.dart

@@ -2511,7 +2511,7 @@ class PasteEditorCommand extends EditCommand {
     }
 
     late DocumentPosition documentPositionAfterPaste;
-    if (parsedContent.length > 1) {
+    if (parsedContent.length > 1 || parsedContent.first is! TextNode ) {
       // Place the caret at the end of the pasted content.
       final pastedNode = document.getNodeById(previousNode.id)!;
       // ^ re-query the node where we pasted content because nodes are immutable.
@@ -2520,14 +2520,12 @@ class PasteEditorCommand extends EditCommand {
         nodePosition: pastedNode.endPosition,
       );
     } else {
-      // The user only pasted content without any newlines in it. Place the
-      // caret in the existing node at the end of the pasted text. This is
-      // guaranteed to be a TextNode.
+      // The user only pasted text content without any newlines in it. Place the
+      // caret in the existing text node at the end of the pasted text.
       documentPositionAfterPaste = DocumentPosition(
         nodeId: _pastePosition.nodeId,
         nodePosition: TextNodePosition(
-          offset:
-              pasteTextOffset + (_parsedContent!.first as TextNode).text.length,
+          offset: pasteTextOffset + (_parsedContent!.first as TextNode).text.length,
         ),
       );
     }

super_editor/test/super_editor/supereditor_copy_and_paste_test.dart

@@ -7,6 +7,7 @@ import 'package:super_editor/super_editor.dart';
 import 'package:super_editor/super_editor_test.dart';
 
 import '../test_runners.dart';
+import '../test_tools.dart';
 import 'supereditor_test_tools.dart';
 
 void main() {
@@ -33,7 +34,8 @@ void main() {
 
       // Ensure that the text was pasted into the paragraph.
       final nodeId = doc.first.id;
-      expect(SuperEditorInspector.findTextInComponent(nodeId).toPlainText(), "Pasted text: This was pasted here");
+      expect(SuperEditorInspector.findTextInComponent(nodeId).toPlainText(),
+          "Pasted text: This was pasted here");
     });
 
     testAllInputsOnDesktop(
@@ -50,15 +52,15 @@ void main() {
 
       // Place the caret at the empty paragraph.
       await tester.placeCaretInParagraph('1', 0);
-      
+
       // Type some text.
       switch (inputSource) {
         case TextInputSource.keyboard:
           await tester.typeKeyboardText('This is a paragraph');
         case TextInputSource.ime:
           await tester.typeImeText('This is a paragraph');
       }
-      
+
       // Place the cursor somewhere in the middle of the text.
       await tester.placeCaretInParagraph('1', 8);
 
@@ -79,12 +81,11 @@ void main() {
       expect((doc.getNodeAt(0)! as ParagraphNode).text.toPlainText(),
           'This is some content in a paragraph');
       final selection = testContext.composer.selection;
-      expect(selection, isNotNull);
-      expect(selection!.isCollapsed, isTrue);
-      expect((selection.base.nodePosition as TextNodePosition).offset, 24);
+      expect(selection, selectionEquivalentTo(
+        const DocumentSelection.collapsed(
+          position: DocumentPosition(nodeId: '1', nodePosition: TextNodePosition(offset: 24)))));
     });
 
-
     testWidgetsOnApple('pastes within a list item', (tester) async {
       await tester //
           .createDocument()
@@ -96,7 +97,8 @@ void main() {
 
       // Place the caret at the end of the list item.
       await tester.placeCaretInParagraph(doc.first.id, 12);
-      await tester.typeImeText(" "); // <- manually add a space because Markdown strips it
+      await tester.typeImeText(
+          " "); // <- manually add a space because Markdown strips it
 
       // Paste text into the paragraph.
       tester
@@ -106,7 +108,8 @@ void main() {
 
       // Ensure that the text was pasted into the paragraph.
       final nodeId = doc.first.id;
-      expect(SuperEditorInspector.findTextInComponent(nodeId).toPlainText(), "Pasted text: This was pasted here");
+      expect(SuperEditorInspector.findTextInComponent(nodeId).toPlainText(),
+          "Pasted text: This was pasted here");
     });
 
     testAllInputsOnDesktop('pastes multiple paragraphs', (
@@ -137,12 +140,16 @@ This is the third paragraph''');
       // Ensure three paragraphs were created.
       final doc = testContext.document;
       expect(doc.nodeCount, 3);
-      expect((doc.getNodeAt(0)! as ParagraphNode).text.toPlainText(), 'This is a paragraph');
-      expect((doc.getNodeAt(1)! as ParagraphNode).text.toPlainText(), 'This is a second paragraph');
-      expect((doc.getNodeAt(2)! as ParagraphNode).text.toPlainText(), 'This is the third paragraph');
+      expect((doc.getNodeAt(0)! as ParagraphNode).text.toPlainText(),
+          'This is a paragraph');
+      expect((doc.getNodeAt(1)! as ParagraphNode).text.toPlainText(),
+          'This is a second paragraph');
+      expect((doc.getNodeAt(2)! as ParagraphNode).text.toPlainText(),
+          'This is the third paragraph');
     });
 
-    testAllInputsOnAllPlatforms("paste retains node IDs when replayed during undo", (
+    testAllInputsOnAllPlatforms(
+        "paste retains node IDs when replayed during undo", (
       tester, {
       required TextInputSource inputSource,
     }) async {
@@ -168,7 +175,8 @@ This is the third paragraph''');
       }
 
       // Gather the current node IDs in the document.
-      final originalNodeIds = testContext.document.toList().map((node) => node.id).toList();
+      final originalNodeIds =
+          testContext.document.toList().map((node) => node.id).toList();
 
       // Pump enough time to separate the next text entry from the paste action.
       await tester.pump(const Duration(seconds: 2));
@@ -186,11 +194,14 @@ This is the third paragraph''');
 
       // Ensure that the node IDs in the document didn't change after re-running
       // the paste command.
-      final newNodeIds = testContext.document.toList().map((node) => node.id).toList();
+      final newNodeIds =
+          testContext.document.toList().map((node) => node.id).toList();
       expect(newNodeIds, originalNodeIds);
     });
 
-    testWidgetsOnMac("paste command content does not mutate when document changes", (tester) async {
+    testWidgetsOnMac(
+        "paste command content does not mutate when document changes",
+        (tester) async {
       final testContext = await tester //
           .createDocument()
           .withSingleEmptyParagraph()