SuperTextField bugfixes

[matthew-carroll]

At the moment, SuperTextField works on both desktop and mobile, but it has a number of bugs.

This milestone covers a number of bugfixes for SuperTextField.

• [SuperTextField] [iOS] [Android] maxLines not respected on mobile #505
• [SuperTextField] [iOS] Text is entered in reverse order #504
• [SuperTextField] [Android] Backspace not working #506
• SuperTextField - Exception when rendering BlinkingTextCaret on web  #459
• [SuperTextField] [web] Support IME input on desktop web #529
• [SuperTextField] [Android] Dragging cursor goes outside widget boundaries #508
• Can't type fast on Android #444
• SuperTextField - caret blinks while typing #460
• Add cursor style support for SuperTextField #383
• [SuperEditor] Drag to select skips one character in the upstream direction #549
• Add SuperTextField mobile text entry tests #620
• Add mobile SuperTextField tests for drag handles #621
• Don't require a line height for SuperTextField #622
• SuperTextField onRightClick should be invoked on tap down #278
• Incorrect Windows CTRL + Arrow Keys behavior #275
• Potential bug in the CaretBlinkController implementation #523
• Convert SuperTextField shortcut tests to user interaction tests #619
• Blockquote not working properly #583

Funders

Turtle, Superlist

[matthew-carroll]

@venkatd - would you like to list the priority order of the bugfixes from your perspective?

[matthew-carroll]

@venkatd I think we should choose a specific set of tickets for this milestone and then work towards completion. Otherwise the milestone may never end. We can always file another milestone after this one.

Does this list still represent your priorities for text field bug fixes?

[matthew-carroll]

It looks like #508 #509 #510 are also filed against super text field. Should those be included?

[venkatd]

@matthew-carroll yes that's right I'd keep the issues above as the right order of priorities. I've added #508 to the list but have left the other two out because they are low priority compared to the list above.

[matthew-carroll]

What do you think about adding some testing tools to this milestone? I think that some of the bugs may be the result of a lack of testing infrastructure. I'm thinking about.

Easy text field content asserts:

// The "{", "}" characters represent bold. The "|" represents the caret.
// The meaning of surrounding characters, like "{ }" still needs some thought.
// We'll want them to be configurable, but also we want the standard case to
// be easy to parse. Maybe we parse Markdown as the standard format...
expect(find.byType(SuperTextField), hasText("Hello, {world!}|"));

Extensions for WidgetTester:

await tester.tapAtTextOffset(5);

await tester.doubleTapAtTextOffset(5);

await tester.dragExpandSelectionTo(10);

await tester.pressRight();

await tester.pressShiftRight();

await tester.pressShiftAltRight();

A fake TextLayout implementation so that some multi-line behaviors can be tested without figuring out exactly how Flutter's Ahem font lays out text in a widget test.

What do you think?

[venkatd]

@matthew-carroll that sounds good to me.

I don't understand the full details of it, but if it helps stabilize things, let's go for it!