[SuperEditor] - Attributions not placed according to markdown standard when serializing document

[edhom]

The AttributedTextMarkdownSerializer places markdown formatting symbols according to the offset of attribution markers. This results in invalid markdown, as the markdown standard doesn't allow leading/trailing whitespaces.

I'm unsure whether the correct fix is in the AttributedTextMarkdownSerializer, or instead to update the attribution markers already while editing to exclude whitespace.

To Reproduce

Screen.Recording.2024-11-27.at.09.23.20.mov

Actual behavior
Super** editor**

Expected behavior
Super editor

[edhom]

I'm unsure whether the correct fix is in the AttributedTextMarkdownSerializer, or instead to update the attribution markers already while editing to exclude whitespace.

@matthew-carroll If you could guide me on this question, I would try to come up with a PR:)

[matthew-carroll]

Hi @edhom - can you please link to the part of the Markdown spec that says this?

WRT a PR/work - the best place to start is to write a bundle of failing tests that demonstrate all the edge cases you can think of for this rule. We already have many tests written in the super_editor_markdown package. You can check if there's a place within the existing files where these tests would fit. If for some reason these tests are sufficiently different in purpose from all existing tests, then you can create a new file.

If you put up a draft PR and tag me and @angelosilvestre with those tests then we can better understand the implications of this change, and help figure out where the change should be implemented.

[edhom]

@matthew-carroll Thanks a lot, I followed up here: #2452

[umar-meetingai]

hi @matthew-carroll is there any update regarding this? i think i also stumbled upon this issue

cc @angelosilvestre