Skip to content

[SuperEditor] Detach plugins in dispose(). (Resolves #2790) #2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SuperEditor] Detach plugins in dispose(). (Resolves #2790) #2793

wants to merge 1 commit into from

Conversation

angelosilvestre
Copy link
Collaborator

[SuperEditor] Detach plugins in dispose(). (Resolves #2790)

Currently, SuperEditor only detaches its plugins on didUpdateWidget. It should be also detaching on dispose, to give the opportunity for plugins to dispose their own dependencies when the editor is removed from the widget tree.

This PR changes SuperEditor to call detach on each plugin on dispose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-carroll matthew-carroll Awaiting requested review from matthew-carroll

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SuperEditor] - Plugins aren't detached in dispose()
1 participant
@angelosilvestre