Skip to content

Commit b868c27

Browse files
committed
update default_logger.dart
1 parent 9580d7c commit b868c27

File tree

3 files changed

+16
-6
lines changed

3 files changed

+16
-6
lines changed

lib/src/interface/rx_storage.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import 'dart:async';
22

3+
import '../../rx_storage.dart';
34
import '../impl/real_storage.dart';
45
import '../logger/logger.dart';
56
import 'storage.dart';

lib/src/logger/default_logger.dart

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import 'package:meta/meta.dart';
2+
13
import 'event.dart';
24
import 'logger.dart';
35

@@ -11,6 +13,7 @@ class DefaultLogger<Key extends Object, Options>
1113
/// Construct a [DefaultLogger].
1214
const DefaultLogger();
1315

16+
@nonVirtual
1417
@override
1518
void log(LoggerEvent<Key, Options> event) {
1619
//
@@ -142,9 +145,13 @@ class DefaultLogger<Key extends Object, Options>
142145
// END: WRITE
143146
//
144147

145-
throw Exception('Unhandled event: $event');
148+
logOther(event);
146149
}
147150

151+
/// Logs other events.
152+
void logOther(LoggerEvent<Key, Options> event) =>
153+
throw Exception('Unhandled event: $event');
154+
148155
static String _concatOptionsIfNotNull(Object? options,
149156
[String separator = ',']) =>
150157
options == null ? '' : '$separator options=$options';

test/fake_storage.dart

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,14 @@ abstract class StringKeyStorage extends Storage<String, void> {
1313
abstract class StringKeyRxStorage extends StringKeyStorage
1414
implements RxStorage<String, void> {}
1515

16-
class FakeDefaultLogger extends DefaultLogger<String, void> {
16+
abstract class FakeLogger extends Logger<String, void> {}
17+
18+
class FakeDefaultLogger extends DefaultLogger<String, void>
19+
implements FakeLogger {
1720
const FakeDefaultLogger();
1821

1922
@override
20-
void log(LoggerEvent<String, void> event) {
23+
void logOther(LoggerEvent<String, void> event) {
2124
if (event is ReloadSuccessEvent) {
2225
print('ReloadSuccessEvent ${event.map}');
2326
return;
@@ -26,8 +29,7 @@ class FakeDefaultLogger extends DefaultLogger<String, void> {
2629
print('ReloadFailureEvent ${event.error}');
2730
return;
2831
}
29-
30-
super.log(event);
32+
super.logOther(event);
3133
}
3234
}
3335

@@ -114,7 +116,7 @@ class FakeRxStorage extends RealRxStorage<String, void, StringKeyStorage>
114116
implements StringKeyRxStorage, StringKeyStorage {
115117
FakeRxStorage(
116118
FutureOr<StringKeyStorage> storageOrFuture, [
117-
Logger<String, void>? logger,
119+
FakeLogger? logger,
118120
void Function()? onDispose,
119121
]) : super(
120122
storageOrFuture,

0 commit comments

Comments
 (0)