Skip to content

Fix broken videos #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 4, 2024
Merged

Fix broken videos #167

merged 6 commits into from
Oct 4, 2024

Conversation

pinkeshmars
Copy link
Collaborator

@pinkeshmars pinkeshmars commented Oct 2, 2024

Description

Fix broken videos

Linear ticket and magic word Fixes DEVR-578

Also Fixes DEVR-592

Type of change

  • Typo fix
  • New feature
  • Enhancement to current docs
  • Removed outdated references
  • Update assets

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot requested a review from PoojaB26 October 2, 2024 06:39
@PoojaB26
Copy link
Collaborator

PoojaB26 commented Oct 3, 2024

@pinkeshmars what are the changes in the videos? I see that only one video is broken in the published docs so can you explain what are these new Arcades we are replacing the old ones with?

@pinkeshmars
Copy link
Collaborator Author

pinkeshmars commented Oct 4, 2024

@pinkeshmars what are the changes in the videos? I see that only one video is broken in the published docs so can you explain what are these new Arcades we are replacing the old ones with?

@PoojaB26
Ya so, previously all four Arcades used GIFs. The issue was that when the page was loaded for the first time, only one Arcade appeared broken. However, if you reloaded the page multiple times (hoping to see the initial Arcade fixed), you’d eventually notice that other Arcades also became broken.

To resolve this, we’ve fully replaced the GIFs with actual videos, which has fixed the issue.

@PoojaB26 PoojaB26 merged commit 9d78660 into main Oct 4, 2024
1 check passed
@PoojaB26 PoojaB26 deleted the pinkesh/rest-api-fix-videos branch October 4, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants