Skip to content

Commit 0f44829

Browse files
authored
⚡️ Enables gaplessPlayback by default for image assets (#569)
## What does this change? Image assets are finalized during builds, they cannot be changed during the runtime. The `gaplessPlayback` defaults to `false` which might lead to images flashing between routes when the provider changes, which it doesn't in fact. Now we change it to `true` to ignore changes to provide a good display experience. This can also considered as a non-breaking change in most cases. ## Type of change - [x] New feature (non-breaking change which adds functionality)
1 parent d29f6bd commit 0f44829

File tree

16 files changed

+16
-16
lines changed

16 files changed

+16
-16
lines changed

examples/example/lib/gen/assets.gen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ class AssetGenImage {
247247
ImageRepeat repeat = ImageRepeat.noRepeat,
248248
Rect? centerSlice,
249249
bool matchTextDirection = false,
250-
bool gaplessPlayback = false,
250+
bool gaplessPlayback = true,
251251
bool isAntiAlias = false,
252252
String? package,
253253
FilterQuality filterQuality = FilterQuality.low,

examples/example_resources/lib/gen/assets.gen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class AssetGenImage {
9494
ImageRepeat repeat = ImageRepeat.noRepeat,
9595
Rect? centerSlice,
9696
bool matchTextDirection = false,
97-
bool gaplessPlayback = false,
97+
bool gaplessPlayback = true,
9898
bool isAntiAlias = false,
9999
@Deprecated('Do not specify package for a generated library asset')
100100
String? package = package,

packages/command/example/lib/gen/assets.gen.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/core/example/lib/gen/assets.gen.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/core/lib/generators/integrations/image_integration.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ ${isPackage ? "\n static const String package = '$packageName';" : ''}
5757
ImageRepeat repeat = ImageRepeat.noRepeat,
5858
Rect? centerSlice,
5959
bool matchTextDirection = false,
60-
bool gaplessPlayback = false,
60+
bool gaplessPlayback = true,
6161
bool isAntiAlias = false,
6262
${isPackage ? deprecationMessagePackage : ''}
6363
String? package$packageParameter,

packages/core/test_resources/actual_data/assets.gen.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/core/test_resources/actual_data/assets_camel_case.gen.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/core/test_resources/actual_data/assets_change_class_name.gen.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/core/test_resources/actual_data/assets_directory_path.gen.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/core/test_resources/actual_data/assets_flavored.gen.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)