✨ Add package to generated assets, pt.2 (#439)

## What does this change?

Further updates to #401.

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)

Author: AlexV525

examples/example_resources/lib/gen/assets.gen.dart

@@ -88,7 +88,8 @@ class AssetGenImage {
     bool matchTextDirection = false,
     bool gaplessPlayback = false,
     bool isAntiAlias = false,
-    @deprecated String? package = package,
+    @Deprecated('Do not specify package for a generated library asset')
+    String? package = package,
     FilterQuality filterQuality = FilterQuality.low,
     int? cacheWidth,
     int? cacheHeight,
@@ -148,7 +149,7 @@ class SvgGenImage {
     Key? key,
     bool matchTextDirection = false,
     AssetBundle? bundle,
-    @Deprecated('Do not use package for a package asset')
+    @Deprecated('Do not specify package for a generated library asset')
     String? package = package,
     double? width,
     double? height,
@@ -300,7 +301,7 @@ class LottieGenImage {
     double? height,
     BoxFit? fit,
     AlignmentGeometry? alignment,
-    @Deprecated('Do not use package for a package asset')
+    @Deprecated('Do not specify package for a generated library asset')
     String? package = package,
     bool? addRepaintBoundary,
     FilterQuality? filterQuality,

packages/core/lib/generators/assets_generator.dart

@@ -571,7 +571,8 @@ ${isPackage ? "\n  static const String package = '$packageName';" : ''}
     bool matchTextDirection = false,
     bool gaplessPlayback = false,
     bool isAntiAlias = false,
-    ${isPackage ? '@deprecated ' : ''}String? package$packageParameter,
+    ${isPackage ? deprecationMessagePackage : ''}
+    String? package$packageParameter,
     FilterQuality filterQuality = FilterQuality.low,
     int? cacheWidth,
     int? cacheHeight,
@@ -606,6 +607,7 @@ ${isPackage ? "\n  static const String package = '$packageName';" : ''}
 
   ImageProvider provider({
     AssetBundle? bundle,
+    ${isPackage ? deprecationMessagePackage : ''}
     String? package$packageParameter,
   }) {
     return AssetImage(

packages/core/lib/generators/integrations/integration.dart

@@ -20,3 +20,8 @@ abstract class Integration {
 
   bool get isConstConstructor;
 }
+
+/// The deprecation message for the package argument
+/// if the asset is a library asset.
+const String deprecationMessagePackage =
+    "@Deprecated('Do not specify package for a generated library asset')";

packages/core/lib/generators/integrations/lottie_integration.dart

@@ -55,7 +55,8 @@ ${isPackage ? "\n  static const String package = '$packageParameterLiteral';" :
     double? height,
     BoxFit? fit,
     AlignmentGeometry? alignment,
-    ${isPackage ? '@deprecated ' : ''}String? package$packageExpression,
+    ${isPackage ? deprecationMessagePackage : ''}
+    String? package$packageExpression,
     bool? addRepaintBoundary,
     FilterQuality? filterQuality,
     void Function(String)? onWarning,

packages/core/lib/generators/integrations/svg_integration.dart

@@ -20,13 +20,15 @@ class SvgIntegration extends Integration {
   const SvgGenImage(this._assetName);
 
   final String _assetName;
-${isPackage ? "\n  static const String package = '$packageParameterLiteral';" : ''}
+
+  ${isPackage ? "static const String package = '$packageParameterLiteral';" : ''}
 
   SvgPicture svg({
     Key? key,
     bool matchTextDirection = false,
     AssetBundle? bundle,
-    ${isPackage ? '@deprecated ' : ''}String? package$packageExpression,
+    ${isPackage ? deprecationMessagePackage : ''}
+    String? package$packageExpression,
     double? width,
     double? height,
     BoxFit fit = BoxFit.contain,

packages/core/test/assets_gen_test.dart

@@ -79,7 +79,13 @@ void main() {
       expect(content, contains("static const String package = 'test';"));
       expect(
         content,
-        contains('@deprecated String? package = package,'),
+        contains(
+          "@Deprecated('Do not specify package for a generated library asset')",
+        ),
+      );
+      expect(
+        content,
+        contains('String? package = package,'),
       );
     });