🎨 The formatter will only use the tall-style if the SDK constraint is ^3.7

Author: AlexV525

packages/core/lib/flutter_generator.dart

@@ -1,11 +1,11 @@
 import 'dart:io' show stdout, Directory, File;
 
-import 'package:dart_style/dart_style.dart' show DartFormatter;
 import 'package:flutter_gen_core/generators/assets_generator.dart';
 import 'package:flutter_gen_core/generators/colors_generator.dart';
 import 'package:flutter_gen_core/generators/fonts_generator.dart';
 import 'package:flutter_gen_core/settings/config.dart';
 import 'package:flutter_gen_core/utils/file.dart';
+import 'package:flutter_gen_core/utils/formatter.dart';
 import 'package:path/path.dart' show join, normalize;
 
 class FlutterGenerator {
@@ -29,15 +29,10 @@ class FlutterGenerator {
       return;
     }
 
+    final formatter = buildDartFormatterFromConfig(config);
     final flutter = config.pubspec.flutter;
     final flutterGen = config.pubspec.flutterGen;
     final output = config.pubspec.flutterGen.output;
-    final lineLength = config.pubspec.flutterGen.lineLength;
-    final formatter = DartFormatter(
-      languageVersion: DartFormatter.latestLanguageVersion,
-      pageWidth: lineLength,
-      lineEnding: '\n',
-    );
 
     void defaultWriter(String contents, String path) {
       final file = File(path);

packages/core/lib/settings/pubspec.dart

@@ -1,4 +1,5 @@
 import 'package:json_annotation/json_annotation.dart';
+import 'package:pub_semver/pub_semver.dart' show VersionConstraint;
 
 part 'pubspec.g.dart';
 
@@ -8,6 +9,7 @@ part 'pubspec.g.dart';
 class Pubspec {
   const Pubspec({
     required this.packageName,
+    required this.environment,
     required this.flutterGen,
     required this.flutter,
   });
@@ -17,13 +19,58 @@ class Pubspec {
   @JsonKey(name: 'name', required: true)
   final String packageName;
 
+  @JsonKey(name: 'environment', fromJson: _environmentFromJson)
+  final Map<String, VersionConstraint?> environment;
+
   @JsonKey(name: 'flutter_gen', required: true)
   final FlutterGen flutterGen;
 
   @JsonKey(name: 'flutter', required: true)
   final Flutter flutter;
 }
 
+// https://github.com/dart-lang/tools/blob/d3b54e89c4f71a114554499dec00ecd87a491b2b/pkgs/pubspec_parse/lib/src/pubspec.dart#L203
+Map<String, VersionConstraint?> _environmentFromJson(Map? source) {
+  if (source == null) {
+    return {};
+  }
+  return source.map((k, value) {
+    final key = k as String;
+    if (key == 'dart') {
+      // github.com/dart-lang/pub/blob/d84173eeb03c3/lib/src/pubspec.dart#L342
+      // 'dart' is not allowed as a key!
+      throw CheckedFromJsonException(
+        source,
+        'dart',
+        'VersionConstraint',
+        'Use "sdk" to for Dart SDK constraints.',
+        badKey: true,
+      );
+    }
+
+    VersionConstraint? constraint;
+    if (value == null) {
+      constraint = null;
+    } else if (value is String) {
+      try {
+        constraint = VersionConstraint.parse(value);
+      } on FormatException catch (e) {
+        throw CheckedFromJsonException(source, key, 'Pubspec', e.message);
+      }
+
+      return MapEntry(key, constraint);
+    } else {
+      throw CheckedFromJsonException(
+        source,
+        key,
+        'VersionConstraint',
+        '`$value` is not a String.',
+      );
+    }
+    return MapEntry(key, constraint);
+  });
+}
+
 @JsonSerializable(disallowUnrecognizedKeys: false)
 class Flutter {
   const Flutter({

packages/core/lib/settings/pubspec.g.dart

@@ -0,0 +1,20 @@
+import 'package:dart_style/dart_style.dart' show DartFormatter;
+import 'package:pub_semver/pub_semver.dart' show VersionConstraint;
+
+import '../settings/config.dart' show Config;
+
+/// The formatter will only use the tall-style if the SDK constraint is ^3.7.
+DartFormatter buildDartFormatterFromConfig(Config config) {
+  final sdkConstraint = config.pubspec.environment['sdk'];
+  final useShort = switch (sdkConstraint) {
+    final c? => c.allowsAny(VersionConstraint.parse('<3.7.0')),
+    _ => true,
+  };
+  return DartFormatter(
+    languageVersion: useShort
+        ? DartFormatter.latestShortStyleLanguageVersion
+        : DartFormatter.latestLanguageVersion,
+    pageWidth: config.pubspec.flutterGen.lineLength,
+    lineEnding: '\n',
+  );
+}

packages/core/lib/utils/formatter.dart

@@ -7,7 +7,7 @@
 /// 2. Built-in identifiers.
 /// 3. Limited reserved words.
 /// 4. Reserved words, which can’t be identifiers.
-///
+// ignore: unnecessary_library_name
 library identifer;
 
 // 1. Contextual keywords, which have meaning only in specific places. They’re

packages/core/lib/utils/identifer.dart

@@ -1,12 +1,12 @@
 import 'dart:io';
 
-import 'package:dart_style/dart_style.dart';
 import 'package:dartx/dartx.dart';
 import 'package:flutter_gen_core/generators/assets_generator.dart';
 import 'package:flutter_gen_core/generators/generator_helper.dart';
 import 'package:flutter_gen_core/settings/asset_type.dart';
 import 'package:flutter_gen_core/settings/config.dart';
 import 'package:flutter_gen_core/utils/error.dart';
+import 'package:flutter_gen_core/utils/formatter.dart';
 import 'package:flutter_gen_core/utils/string.dart';
 import 'package:test/test.dart';
 
@@ -59,11 +59,7 @@ void main() {
     test('Assets with No lists on pubspec.yaml', () async {
       final pubspec = File('test_resources/pubspec_assets_no_list.yaml');
       final config = loadPubspecConfig(pubspec);
-      final formatter = DartFormatter(
-        languageVersion: dartFormatterLanguageVersion,
-        pageWidth: config.pubspec.flutterGen.lineLength,
-        lineEnding: '\n',
-      );
+      final formatter = buildDartFormatterFromConfig(config);
 
       expect(
         () => generateAssets(

packages/core/test/assets_gen_test.dart

@@ -1,10 +1,10 @@
 import 'dart:io';
 
-import 'package:dart_style/dart_style.dart';
 import 'package:flutter_gen_core/generators/colors_generator.dart';
 import 'package:flutter_gen_core/settings/color_path.dart';
 import 'package:flutter_gen_core/settings/config.dart';
 import 'package:flutter_gen_core/utils/error.dart';
+import 'package:flutter_gen_core/utils/formatter.dart';
 import 'package:test/test.dart';
 
 import 'gen_test_helper.dart';
@@ -22,11 +22,7 @@ void main() {
     test('Wrong colors settings on pubspec.yaml', () async {
       final pubspec = File('test_resources/pubspec_colors_no_inputs.yaml');
       final config = loadPubspecConfig(pubspec);
-      final formatter = DartFormatter(
-        languageVersion: dartFormatterLanguageVersion,
-        pageWidth: config.pubspec.flutterGen.lineLength,
-        lineEnding: '\n',
-      );
+      final formatter = buildDartFormatterFromConfig(config);
 
       expect(
         () => generateColors(
@@ -41,11 +37,7 @@ void main() {
     test('Wrong colors settings on pubspec.yaml', () async {
       final pubspec = File('test_resources/pubspec_colors_no_inputs_list.yaml');
       final config = loadPubspecConfig(pubspec);
-      final formatter = DartFormatter(
-        languageVersion: dartFormatterLanguageVersion,
-        pageWidth: config.pubspec.flutterGen.lineLength,
-        lineEnding: '\n',
-      );
+      final formatter = buildDartFormatterFromConfig(config);
 
       expect(
         () {

packages/core/test/colors_gen_test.dart

@@ -1,9 +1,9 @@
 import 'dart:io';
 
-import 'package:dart_style/dart_style.dart';
 import 'package:flutter_gen_core/generators/fonts_generator.dart';
 import 'package:flutter_gen_core/settings/config.dart';
 import 'package:flutter_gen_core/utils/error.dart';
+import 'package:flutter_gen_core/utils/formatter.dart';
 import 'package:test/test.dart';
 
 import 'gen_test_helper.dart';
@@ -22,11 +22,7 @@ void main() {
       final config = loadPubspecConfig(
         File('test_resources/pubspec_fonts_no_family.yaml'),
       );
-      final formatter = DartFormatter(
-        languageVersion: dartFormatterLanguageVersion,
-        pageWidth: config.pubspec.flutterGen.lineLength,
-        lineEnding: '\n',
-      );
+      final formatter = buildDartFormatterFromConfig(config);
 
       expect(
         () => generateFonts(FontsGenConfig.fromConfig(config), formatter),

packages/core/test/fonts_gen_test.dart

@@ -1,16 +1,14 @@
 import 'dart:io';
 
-import 'package:dart_style/dart_style.dart';
 import 'package:flutter_gen_core/flutter_generator.dart';
 import 'package:flutter_gen_core/generators/assets_generator.dart';
 import 'package:flutter_gen_core/generators/colors_generator.dart';
 import 'package:flutter_gen_core/generators/fonts_generator.dart';
 import 'package:flutter_gen_core/settings/config.dart';
+import 'package:flutter_gen_core/utils/formatter.dart';
 import 'package:path/path.dart' as p;
 import 'package:test/test.dart';
 
-final dartFormatterLanguageVersion = DartFormatter.latestLanguageVersion;
-
 Future<void> clearTestResults() async {}
 
 Future<List<String>> runAssetsGen(
@@ -35,11 +33,7 @@ Future<List<String>> runAssetsGen(
 
   stdout.writeln('[DEBUG] test: Generate from API...');
   final config = loadPubspecConfig(pubspecFile, buildFile: buildFile);
-  final formatter = DartFormatter(
-    languageVersion: dartFormatterLanguageVersion,
-    pageWidth: config.pubspec.flutterGen.lineLength,
-    lineEnding: '\n',
-  );
+  final formatter = buildDartFormatterFromConfig(config);
 
   final actual = await generateAssets(
     AssetsGenConfig.fromConfig(pubspecFile, config),
@@ -79,11 +73,7 @@ Future<List<String>> runColorsGen(
 
   final pubspecFile = File(pubspec);
   final config = loadPubspecConfig(pubspecFile);
-  final formatter = DartFormatter(
-    languageVersion: dartFormatterLanguageVersion,
-    pageWidth: config.pubspec.flutterGen.lineLength,
-    lineEnding: '\n',
-  );
+  final formatter = buildDartFormatterFromConfig(config);
 
   final actual = generateColors(
     pubspecFile,
@@ -123,11 +113,7 @@ Future<List<String>> runFontsGen(
 
   final pubspecFile = File(pubspec);
   final config = loadPubspecConfig(pubspecFile);
-  final formatter = DartFormatter(
-    languageVersion: dartFormatterLanguageVersion,
-    pageWidth: config.pubspec.flutterGen.lineLength,
-    lineEnding: '\n',
-  );
+  final formatter = buildDartFormatterFromConfig(config);
 
   final actual = generateFonts(
     FontsGenConfig.fromConfig(config),