Skip to content

Commit 9247b38

Browse files
authored
chore: fix concurrency execute with melos. (#563)
## What does this change? I limited concurrent execution because these logs were being output during the execution of the flutter command. When `melos run get` ``` ERROR: ERROR: [example]: Waiting for another flutter command to release the startup lock... ERROR: ERROR: [flutter_gen]: Waiting for another flutter command to release the startup lock... ERROR: ERROR: [flutter_gen_runner]: Waiting for another flutter command to release the startup lock... ``` And fix analyze. ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## Checklist: Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests (`melos run test`) - [x] Ensure the analyzer and formatter pass (`melos run format` to automatically apply formatting) - [ ] Appropriate docs were updated (if necessary)
1 parent 38f121f commit 9247b38

File tree

8 files changed

+20
-20
lines changed

8 files changed

+20
-20
lines changed

examples/example/test/svg_integrations_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
@TestOn('vm')
21
import 'package:example/gen/assets.gen.dart';
32
import 'package:flutter/material.dart';
43
import 'package:flutter_svg/flutter_svg.dart';

melos.yaml

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,28 +9,31 @@ ide:
99
intellij:
1010
enabled: true
1111
moduleNamePrefix: ''
12-
vscode: true
1312

1413
command:
1514
clean:
1615
hooks:
1716
post:
18-
run: |
19-
melos exec -c 6 -- flutter clean
17+
run: flutter clean
18+
exec:
19+
concurrency: 1
2020
description: flutter clean
2121

2222
scripts:
2323
get:
24-
run: |
25-
melos exec -c 6 -- flutter pub get
24+
run: flutter pub get
25+
exec:
26+
concurrency: 1
2627
description: flutter pub get
2728

2829
upgrade:
29-
run: melos exec -c 6 -- flutter pub upgrade
30+
run: flutter pub upgrade
31+
exec:
32+
concurrency: 1
3033
description: flutter pub upgrade
3134

3235
analyze:
33-
run: melos exec -c 6 -- flutter analyze
36+
exec: flutter analyze
3437
description: flutter analyze
3538

3639
format:
@@ -53,23 +56,27 @@ scripts:
5356
description: dart run build_runner build --delete-conflicting-outputs
5457

5558
gen:examples:command:
56-
exec: dart ../../packages/command/bin/flutter_gen_command.dart --config pubspec.yaml
59+
exec: dart ../../packages/command/bin/flutter_gen_command.dart
5760
packageFilters:
58-
scope:
61+
scope:
5962
- example
6063
- example_resources
61-
description: dart ../../packages/command/bin/flutter_gen_command.dart --config pubspec.yaml
64+
description: dart ../../packages/command/bin/flutter_gen_command.dart
6265

6366
gen:examples:build_runner:
64-
exec: flutter pub run build_runner build --delete-conflicting-outputs
67+
run: flutter pub run build_runner build --delete-conflicting-outputs
68+
exec:
69+
concurrency: 1
6570
packageFilters:
66-
scope:
71+
scope:
6772
- example
6873
- example_resources
6974
description: flutter pub run build_runner build --delete-conflicting-outputs
7075

7176
test:
72-
run: melos test:dart --no-select && melos test:flutter --no-select
77+
run: |
78+
melos test:dart --no-select
79+
melos test:flutter --no-select
7380
description: dart & flutter test
7481

7582
test:dart:

packages/core/test/assets_gen_integrations_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
@TestOn('vm')
21
import 'package:flutter_gen_core/generators/integrations/flare_integration.dart';
32
import 'package:flutter_gen_core/generators/integrations/integration.dart';
43
import 'package:flutter_gen_core/generators/integrations/lottie_integration.dart';

packages/core/test/assets_gen_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
@TestOn('vm')
21
import 'dart:io';
32

43
import 'package:dart_style/dart_style.dart';

packages/core/test/colors_gen_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
@TestOn('vm')
21
import 'dart:io';
32

43
import 'package:dart_style/dart_style.dart';

packages/core/test/flutter_gen_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
@TestOn('vm')
21
import 'dart:io';
32

43
import 'package:flutter_gen_core/flutter_generator.dart';

packages/core/test/fonts_gen_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
@TestOn('vm')
21
import 'dart:io';
32

43
import 'package:dart_style/dart_style.dart';

packages/core/test/gen_test_helper.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
@TestOn('vm')
21
import 'dart:io';
32

43
import 'package:dart_style/dart_style.dart';

0 commit comments

Comments
 (0)