Skip to content

Commit cfdd992

Browse files
committed
test: fix false positive
1 parent b84ce67 commit cfdd992

File tree

6 files changed

+24
-19
lines changed

6 files changed

+24
-19
lines changed

packages/core/test/assets_gen_integrations_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ void main() {
1717
final generated =
1818
'test_resources/lib/gen/assets_no_integrations.gen.dart';
1919

20-
expectedAssetsGen(pubspec, generated, fact);
20+
await expectedAssetsGen(pubspec, generated, fact);
2121
});
2222

2323
test('Assets with Svg integrations on pubspec.yaml', () async {
@@ -28,7 +28,7 @@ void main() {
2828
'test_resources/lib/gen/assets_svg_integrations.gen.dart';
2929
final config = await loadPubspecConfig(File(pubspec));
3030

31-
expectedAssetsGen(pubspec, generated, fact);
31+
await expectedAssetsGen(pubspec, generated, fact);
3232

3333
final integration = SvgIntegration('package_name',
3434
nullSafety: config.flutterGen.nullSafety);
@@ -48,7 +48,7 @@ void main() {
4848
'test_resources/lib/gen/assets_flare_integrations.gen.dart';
4949
final config = await loadPubspecConfig(File(pubspec));
5050

51-
expectedAssetsGen(pubspec, generated, fact);
51+
await expectedAssetsGen(pubspec, generated, fact);
5252

5353
final integration =
5454
FlareIntegration(nullSafety: config.flutterGen.nullSafety);

packages/core/test/assets_gen_test.dart

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ void main() {
1616
final fact = 'test_resources/actual_data/assets.gen.dart';
1717
final generated = 'test_resources/lib/gen/assets.gen.dart';
1818

19-
expectedAssetsGen(pubspec, generated, fact);
19+
await expectedAssetsGen(pubspec, generated, fact);
2020
});
2121

2222
test('Assets with Disabled Null Safety on pubspec.yaml', () async {
@@ -26,23 +26,23 @@ void main() {
2626
final generated =
2727
'test_resources/lib/gen/assets_disable_null_safety.gen.dart';
2828

29-
expectedAssetsGen(pubspec, generated, fact);
29+
await expectedAssetsGen(pubspec, generated, fact);
3030
});
3131

3232
test('Assets snake-case style on pubspec.yaml', () async {
3333
final pubspec = 'test_resources/pubspec_assets_snake_case.yaml';
3434
final fact = 'test_resources/actual_data/assets_snake_case.gen.dart';
3535
final generated = 'test_resources/lib/gen/assets_snake_case.gen.dart';
3636

37-
expectedAssetsGen(pubspec, generated, fact);
37+
await expectedAssetsGen(pubspec, generated, fact);
3838
});
3939

4040
test('Assets camel-case style on pubspec.yaml', () async {
4141
final pubspec = 'test_resources/pubspec_assets_camel_case.yaml';
4242
final fact = 'test_resources/actual_data/assets_camel_case.gen.dart';
4343
final generated = 'test_resources/lib/gen/assets_camel_case.gen.dart';
4444

45-
expectedAssetsGen(pubspec, generated, fact);
45+
await expectedAssetsGen(pubspec, generated, fact);
4646
});
4747

4848
test('Assets with Unknown mime type on pubspec.yaml', () async {
@@ -52,15 +52,15 @@ void main() {
5252
final generated =
5353
'test_resources/lib/gen/assets_unknown_mime_type.gen.dart';
5454

55-
expectedAssetsGen(pubspec, generated, fact);
55+
await expectedAssetsGen(pubspec, generated, fact);
5656
});
5757

5858
test('Assets with ignore files on pubspec.yaml', () async {
5959
final pubspec = 'test_resources/pubspec_ignore_files.yaml';
6060
final fact = 'test_resources/actual_data/assets_ignore_files.gen.dart';
6161
final generated = 'test_resources/lib/gen/assets_ignore_files.gen.dart';
6262

63-
expectedAssetsGen(pubspec, generated, fact);
63+
await expectedAssetsGen(pubspec, generated, fact);
6464
});
6565

6666
test('Assets with No lists on pubspec.yaml', () async {
@@ -82,17 +82,18 @@ void main() {
8282
final generated =
8383
'test_resources/lib/gen/assets_package_parameter.gen.dart';
8484

85-
expectedAssetsGen(pubspec, generated, fact);
85+
await expectedAssetsGen(pubspec, generated, fact);
8686
});
8787

88-
test('Assets with package parameter enabled', () async {
89-
final pubspec = 'test_resources/pubspec_assets_package_parameter.yaml';
88+
test('Assets with package parameter enabled and disable null safety',
89+
() async {
90+
final pubspec = 'test_resources/pubspec_assets_package_parameter_disable_null_safety.yaml';
9091
final fact =
9192
'test_resources/actual_data/assets_package_parameter_disable_null_safety.gen.dart';
9293
final generated =
9394
'test_resources/lib/gen/assets_package_parameter_disable_null_safety.gen.dart';
9495

95-
expectedAssetsGen(pubspec, generated, fact);
96+
await expectedAssetsGen(pubspec, generated, fact);
9697
});
9798
});
9899
}

packages/core/test/colors_gen_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ void main() {
1717
final fact = 'test_resources/actual_data/colors.gen.dart';
1818
final generated = 'test_resources/lib/gen/colors.gen.dart';
1919

20-
expectedColorsGen(pubspec, generated, fact);
20+
await expectedColorsGen(pubspec, generated, fact);
2121
});
2222

2323
test('Wrong colors settings on pubspec.yaml', () async {

packages/core/test/fonts_gen_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ void main() {
1616
final fact = 'test_resources/actual_data/fonts.gen.dart';
1717
final generated = 'test_resources/lib/gen/fonts.gen.dart';
1818

19-
expectedFontsGen(pubspec, generated, fact);
19+
await expectedFontsGen(pubspec, generated, fact);
2020
});
2121

2222
test('Wrong fonts settings on pubspec.yaml', () async {

packages/core/test/gen_test_helper.dart

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ import 'package:test/test.dart';
1313
Future<void> clearTestResults() async {}
1414

1515
/// Assets
16-
void expectedAssetsGen(String pubspec, String generated, String fact) async {
16+
Future<void> expectedAssetsGen(
17+
String pubspec, String generated, String fact) async {
1718
await FlutterGenerator(File(pubspec), assetsName: basename(generated))
1819
.build();
1920

@@ -35,7 +36,8 @@ void expectedAssetsGen(String pubspec, String generated, String fact) async {
3536
}
3637

3738
/// Colors
38-
void expectedColorsGen(String pubspec, String generated, String fact) async {
39+
Future<void> expectedColorsGen(
40+
String pubspec, String generated, String fact) async {
3941
await FlutterGenerator(File(pubspec)).build();
4042

4143
final pubspecFile = File(pubspec);
@@ -55,7 +57,8 @@ void expectedColorsGen(String pubspec, String generated, String fact) async {
5557
}
5658

5759
/// Fonts
58-
void expectedFontsGen(String pubspec, String generated, String fact) async {
60+
Future<void> expectedFontsGen(
61+
String pubspec, String generated, String fact) async {
5962
await FlutterGenerator(File(pubspec)).build();
6063

6164
final pubspecFile = File(pubspec);

packages/core/test_resources/actual_data/assets_package_parameter_disable_null_safety.gen.dart

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)