[BUG]: `DartFormatter.latestLanguageVersion` is supported by dart_style v2.3.7 and above

[koji-1009]

Is there an existing issue for this?

• I have searched the existing issues

Version

5.9.0

Command type

build_runner (Default)

What happened?

DartFormatter.latestLanguageVersion is used in v5.9.0, but there is a problem with the version of dart_style required by flutter_gen_runner.

https://github.com/FlutterGen/flutter_gen/blob/v5.9.0/packages/core/lib/flutter_generator.dart#L37

DartFormatter.latestLanguageVersion is a property added in dart_style v2.3.7.

https://github.com/dart-lang/dart_style/blob/v2.3.7/lib/src/dart_formatter.dart#L30

https://github.com/dart-lang/dart_style/blob/v2.3.6/lib/src/dart_formatter.dart#L27

However, in pubspec.yaml dart_style: ‘>=2.2.4 <4.0.0’ is specified.

https://github.com/FlutterGen/flutter_gen/blob/v5.9.0/packages/core/pubspec.yaml#L27

This causes flutter_gen_runner to fail to run in projects that use dart_style 2.3.6 or lower versions due to other packages.

Relevant a pubspec.yaml.

Relevant log output

[WARNING] ../../.pub-cache/hosted/pub.dev/flutter_gen_core-5.9.0/lib/flutter_generator.dart:37:38: Error: Member not found: 'latestLanguageVersion'.
      languageVersion: DartFormatter.latestLanguageVersion,
                                     ^^^^^^^^^^^^^^^^^^^^^

Code of Conduct

• I agree to follow this project's Code of Conduct

[koji-1009]

PR has been modified to avoid this problem.

#652

When adding DartFormatter.latestLanguageVersion, it is recommended to include the dart_style version update at the same time.

[hitblast]

Interestingly enough, replacing flutter_gen_runner with flutter_gen inside the dev_dependencies category seems to solve the issue for me. Not sure what's going on under the hood - faced the same build failures.

[AlexV525]

#653 should solve the issue. Could anyone facing the issue verify it?

[hitblast]

#653 should solve the issue. Could anyone facing the issue verify it?

Well here's my build log from Flutter version 3.27.3 of an upcoming project:

[AlexV525]

Well here's my build log from Flutter version 3.27.3 of an upcoming project:

Could you override the core to the ref of the PR to verify? Your log tells that you are still using the pub version.

[arunvkazm]

flutter_gen_core - Error: Member not found: 'latestLanguageVersion'

I'm encountering an issue while running dart run build_runner build with flutter_gen_runner. The build fails with the following error:

../../../../.pub-cache/hosted/pub.dev/flutter_gen_core-5.9.0/lib/flutter_generator.dart:37:38: Error: Member not found: 'latestLanguageVersion'. languageVersion: DartFormatter.latestLanguageVersion, ^^^^^^^^^^^^^^^^^^^^^ ../../../../.pub-cache/hosted/pub.dev/flutter_gen_core-5.9.0/lib/flutter_generator.dart:37:7: Error: No named parameter with the name 'languageVersion'. languageVersion: DartFormatter.latestLanguageVersion, ^^^^^^^^^^^^^^^ ../../../../.pub-cache/hosted/pub.dev/dart_style-2.3.6/lib/src/dart_formatter.dart:58:3: Context: Found this candidate, but the arguments don't match. DartFormatter( ^^^^^^^^^^^^^

Here my pubspec.yaml

`dev_dependencies:
flutter_test:
sdk: flutter

flutter_lints: ^3.0.0
build_runner: ^2.4.6
flutter_gen_runner:

flutter_gen:
output: lib/app/gen/
line_length: 80
assets:
outputs:
style: camel-case
fonts:
outputs:
package_parameter_enabled: true
integrations:
flutter_svg: true`

[koji-1009]

I understand that flutter_gen_builder wants to support the latest dart_style. On the other hand, I also feel that it is not a good idea to break the run build_runner of projects using ‘>=2.2.4 <=2.3.6’ because other packages require the old dart_style. v5.9.0 has this problem.

How about releasing v5.9.1 with dart_style: '>=2.2.4 <3.0.0' and then v5.10.0 with dart_style: '>=2.3.7 <4.0.0' or dart_style: '^3.0.0'? Projects using the old dart_style can update to v5.9.1.

[hitblast]

Well here's my build log from Flutter version 3.27.3 of an upcoming project:

Could you override the core to the ref of the PR to verify? Your log tells that you are still using the pub version.

Okay. Seems like the build successfully completes now.

Building package executable... (2.7s)
Built build_runner:build_runner.
[INFO] Generating build script completed, took 194ms
[WARNING] Throwing away cached asset graph because the build phases have changed. This most commonly would happen as a result of adding a new dependency or updating your dependencies.
[WARNING] Throwing away cached asset graph because the language version of some package(s) changed. This would most commonly happen when updating dependencies or changing your min sdk constraint.
[INFO] Cleaning up outputs from previous builds. completed, took 109ms
[INFO] Generating build script completed, took 60ms
[WARNING] Invalidated precompiled build script due to missing asset graph.
[INFO] Precompiling build script... completed, took 3.5s
[INFO] Building new asset graph completed, took 801ms
[INFO] Checking for unexpected pre-existing outputs. completed, took 0ms
[WARNING] riverpod_generator on lib/core/core_sequences.dart:
Your current `analyzer` version may not fully support your current SDK version.

Analyzer language version: 3.1.0
SDK language version: 3.6.0

Please update to the latest `analyzer` version (7.3.0) by running
`flutter packages upgrade`.

If you are not getting the latest version by running the above command, you
can try adding a constraint like the following to your pubspec to start
diagnosing why you can't get the latest version:

dev_dependencies:
  analyzer: ^7.3.0

[INFO] Running build completed, took 8.9s
[INFO] Caching finalized dependency graph completed, took 42ms
[INFO] Succeeded after 9.0s with 61 outputs (194 actions)

[AlexV525]

I also feel that it is not a good idea to break the run build_runner of projects using ‘>=2.2.4 <=2.3.6’ because other packages require the old dart_style. v5.9.0 has this problem.

@koji-1009 v2 should be compatible with each other, so 2.2.4 can be upgraded to 2.3.7 without pain, no?

[koji-1009]

@AlexV525
I cannot say that there is no library that for some reason has a fixed version of dart_style. At the risk of sounding very defensive, compatibility between libraries is a difficult issue.

This topic appears to be a difficult discussion because v5.9.0 supports dart_style v2.2.4. v2.2.4 supports Dart 2.17.
https://pub.dev/packages/dart_style/versions

If it is not too hard to release, it seems to me that separating the releases would prevent projects using the old Dart from submitting issues. Of course, the maintainer's policy could be to explain that Dart v2 is no longer supported; referring to v5.8.0 should not cause any new problems.