Skip to content

Conversation

@koji-1009
Copy link
Contributor

What does this change?

dart_style v2.3.7 requries dart 3.0.0 or higher.

https://pub.dev/packages/dart_style/versions

Fixes #651 🎯

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

pubspec.yaml Outdated

environment:
sdk: ">=2.17.0 <4.0.0"
sdk: ">=3.0.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pub.dev/packages/melos/versions

melos v6.0.0 requires dart v3.0.0 or higher.

@codecov
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (6f51358) to head (1531997).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files          21       21           
  Lines         819      819           
=======================================
  Hits          799      799           
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


environment:
sdk: '>=2.17.0 <4.0.0'
sdk: '>=3.0.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use ^3.0.0? I believe dart pub publish --dry-run will complain about this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed! 1b0beff

@koji-1009 koji-1009 requested a review from AlexV525 February 9, 2025 14:28
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlexV525 AlexV525 merged commit 74b1d87 into FlutterGen:main Feb 10, 2025
5 checks passed
@koji-1009 koji-1009 deleted the feat/dart_3 branch February 10, 2025 02:44
@AlexV525 AlexV525 mentioned this pull request Mar 2, 2025
AlexV525 added a commit that referenced this pull request Mar 2, 2025
## 5.10.0

**Feature**
- [#659](#659) Add support
Telegram Sticker `.tgs` in Lottie Integration. by
[@dungngminh](https://github.com/dungngminh)

**Bug fix**
- [#653](#653) Constraints
`dart_style` to `>=2.3.7`. by [@AlexV525](https://github.com/AlexV525)
- [#656](#656) Add missing
parameters in Lottie integration from lottie 3.0.0. by
[@dungngminh](https://github.com/dungngminh)
- [#658](#658) Update
required dart version. by [@koji-1009](https://github.com/koji-1009)
@AlexV525 AlexV525 added this to the 5.10.0 milestone Mar 2, 2025
bluesky950520 added a commit to bluesky950520/flutter_gen-edit that referenced this pull request Mar 11, 2025
## 5.10.0

**Feature**
- [#659](FlutterGen/flutter_gen#659) Add support
Telegram Sticker `.tgs` in Lottie Integration. by
[@dungngminh](https://github.com/dungngminh)

**Bug fix**
- [#653](FlutterGen/flutter_gen#653) Constraints
`dart_style` to `>=2.3.7`. by [@AlexV525](https://github.com/AlexV525)
- [#656](FlutterGen/flutter_gen#656) Add missing
parameters in Lottie integration from lottie 3.0.0. by
[@dungngminh](https://github.com/dungngminh)
- [#658](FlutterGen/flutter_gen#658) Update
required dart version. by [@koji-1009](https://github.com/koji-1009)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: DartFormatter.latestLanguageVersion is supported by dart_style v2.3.7 and above

2 participants