-
-
Notifications
You must be signed in to change notification settings - Fork 172
feat: Update required dart version #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pubspec.yaml
Outdated
|
|
||
| environment: | ||
| sdk: ">=2.17.0 <4.0.0" | ||
| sdk: ">=3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://pub.dev/packages/melos/versions
melos v6.0.0 requires dart v3.0.0 or higher.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 21 21
Lines 819 819
=======================================
Hits 799 799
Misses 20 20 ☔ View full report in Codecov by Sentry. |
packages/command/pubspec.yaml
Outdated
|
|
||
| environment: | ||
| sdk: '>=2.17.0 <4.0.0' | ||
| sdk: '>=3.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use ^3.0.0? I believe dart pub publish --dry-run will complain about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed! 1b0beff
AlexV525
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
## 5.10.0 **Feature** - [#659](#659) Add support Telegram Sticker `.tgs` in Lottie Integration. by [@dungngminh](https://github.com/dungngminh) **Bug fix** - [#653](#653) Constraints `dart_style` to `>=2.3.7`. by [@AlexV525](https://github.com/AlexV525) - [#656](#656) Add missing parameters in Lottie integration from lottie 3.0.0. by [@dungngminh](https://github.com/dungngminh) - [#658](#658) Update required dart version. by [@koji-1009](https://github.com/koji-1009)
## 5.10.0 **Feature** - [#659](FlutterGen/flutter_gen#659) Add support Telegram Sticker `.tgs` in Lottie Integration. by [@dungngminh](https://github.com/dungngminh) **Bug fix** - [#653](FlutterGen/flutter_gen#653) Constraints `dart_style` to `>=2.3.7`. by [@AlexV525](https://github.com/AlexV525) - [#656](FlutterGen/flutter_gen#656) Add missing parameters in Lottie integration from lottie 3.0.0. by [@dungngminh](https://github.com/dungngminh) - [#658](FlutterGen/flutter_gen#658) Update required dart version. by [@koji-1009](https://github.com/koji-1009)
What does this change?
dart_style v2.3.7 requries dart 3.0.0 or higher.
https://pub.dev/packages/dart_style/versions
Fixes #651 🎯
Type of change
Please delete options that are not relevant.
Checklist:
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
melos run test)melos run formatto automatically apply formatting)