♻️ Fighting with the Dart formatter #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`Platform.version`
AlexV525
force-pushed
the
feat/write-format-width
branch
from
d6a2a3e to
db47401
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #697 +/- ##
==========================================
- Coverage 96.61% 96.60% -0.01%
==========================================
Files 23 24 +1
Lines 856 883 +27
==========================================
+ Hits 827 853 +26
- Misses 29 30 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
AlexV525
added a commit
that referenced
this pull request
Jul 17, 2025
## 5.11.0 **Feature** - [#576](#576) Add support for deferred components. by [@ianmaciel](https://github.com/ianmaciel) - [#676](#676) Add new option `parse_animation` to parse metadata for animated images. by [@huandu](https://github.com/huandu) - [#680](#680) Add svg `ColorMapper` to svg loader. by [@AlexV525](https://github.com/AlexV525) - [#685](#685) Use `.vec` SVG class for `vector_graphics_compiler` transformed assets. by [@Albert221](https://github.com/Albert221) - [#697](#697) Refactor how generated files are being formatted. by [@AlexV525](https://github.com/AlexV525) **Development** - [#681](#682) Bump `dart_style` v3 which also requires Dart 3.4. by [@AlexV525](https://github.com/AlexV525) - [#682](#682) Add Facts generate utils. by [@AlexV525](https://github.com/AlexV525) - [#694](#694) Use fine-grained logger instead of `stdout.writeln`. by [@AlexV525](https://github.com/AlexV525) - [#698](#698) Improve workflow with automatic formatting. by [@AlexV525](https://github.com/AlexV525) - [#699](#699) Allow `build 3.0.0`. by [@davidmorgan](https://github.com/davidmorgan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Generated files are being formatted based on confusing conditions. The PR refactored how we construct the Dart formatter in a more elegant manner.
pubspec.yaml/pubspec.lock. Otherwise, it will fall back to using the current Dart SDK version as the constraint. The behavior is like:pubspec.yamlhas^3.4.0, andpubspec.lockresolves^3.7.0, the formatter will format like 3.4.0.environment - sdk(and likely does not have apubspec.lock), the formatter will format based on the current Dart SDK version.analysis_options.yaml - formatter - page_width/pubspec.yaml - flutter_gen - line_length, then prepend the format width header to make all format tools respect the config..tgsin Lottie Integration #659 (comment)Type of change