Skip to content

Commit 283496e

Browse files
committed
rm mutation
1 parent 8677b1a commit 283496e

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/softmax.jl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ julia> softmax([1,2,3.])
2121
"""
2222
function softmax(xs::AbstractArray; dims=1)
2323
max_ = maximum(xs, dims=dims)
24-
out = exp.(xs .- max_)
25-
out .= out ./ sum!(max_, out)
24+
exp_ = exp.(xs .- max_)
25+
exp_ ./ sum(exp_, dims=dims)
2626
end
2727

2828
function softmax!(out::AbstractVecOrMat{T}, xs::AbstractVecOrMat{T}) where {T}
@@ -58,7 +58,7 @@ function ∇softmax!(out::AbstractVecOrMat, Δ::AbstractVecOrMat, xs::AbstractVe
5858
end
5959
function ∇softmax(Δ, xs; dims=1)
6060
sf = softmax(xs, dims=dims)
61-
out = sf .*.- sum.* sf, dims=dims))
61+
sf .*.- sum.* sf, dims=dims))
6262
end
6363
∇softmax!(Δ, xs) = ∇softmax!(Δ, Δ, xs)
6464

@@ -72,9 +72,9 @@ computing cross entropy loss.
7272
"""
7373
function logsoftmax(xs::AbstractArray; dims=1)
7474
max_ = maximum(xs, dims=dims)
75-
out = exp.(xs .- max_)
76-
log_ = log.(sum(out, dims=dims))
77-
out .= (xs .- max_) .- log_
75+
exp_ = exp.(xs .- max_)
76+
log_ = log.(sum(exp_, dims=dims))
77+
(xs .- max_) .- log_
7878
end
7979

8080
function logsoftmax!(out::AbstractVecOrMat, xs::AbstractVecOrMat)

0 commit comments

Comments
 (0)