Skip to content

Commit c68bc4b

Browse files
committed
Add compat bounds, buildkite AMDGPU job & fix docs
When running builkite job for the AMDGPU, we populate 'test' target with AMDGPU before running them.
1 parent 9c17a13 commit c68bc4b

File tree

3 files changed

+34
-5
lines changed

3 files changed

+34
-5
lines changed

.buildkite/pipeline.yml

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,35 @@ steps:
5555
if: build.pull_request.labels includes "benchmark"
5656
timeout_in_minutes: 30
5757

58+
- label: "AMDGPU - Julia 1.9 - No Artifacts"
59+
plugins:
60+
- JuliaCI/julia#v1:
61+
version: 1.9-nightly
62+
- JuliaCI/julia-test#v1:
63+
- JuliaCI/julia-coverage#v1:
64+
codecov: true
65+
dirs:
66+
- src
67+
- ext
68+
agents:
69+
queue: "juliagpu"
70+
rocm: "*"
71+
rocmgpu: "*"
72+
command:
73+
- julia -e """
74+
using TOML
75+
conf = TOML.parse(read(\"Project.toml\", String))
76+
push!(conf[\"targets\"][\"test\"], \"AMDGPU\")
77+
open(io -> TOML.print(io, conf), \"Project.toml\", \"w\")
78+
"""
79+
- julia --project -e 'using Pkg; Pkg.update()'
80+
timeout_in_minutes: 30
81+
env:
82+
JULIA_AMDGPU_CORE_MUST_LOAD: "1"
83+
JULIA_AMDGPU_HIP_MUST_LOAD: "1"
84+
JULIA_AMDGPU_DISABLE_ARTIFACTS: "1"
85+
NNLIB_TEST_AMDGPU: true
86+
5887
# - label: "GPU julia nightly"
5988
# plugins:
6089
# - JuliaCI/julia#v1:

Project.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,14 @@ AMDGPU = "21141c5a-9bdb-4563-92ae-f87d6854732e"
1818
AMDGPUExt = "AMDGPU"
1919

2020
[compat]
21-
AMDGPU = "0.4.5"
21+
AMDGPU = "0.4.7"
2222
Adapt = "2, 3.2"
2323
ChainRulesCore = "1.13"
2424
Requires = "0.5, 1.0"
2525
julia = "1.6"
2626

2727
[extras]
28+
AMDGPU = "21141c5a-9bdb-4563-92ae-f87d6854732e"
2829
CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba"
2930
ChainRulesTestUtils = "cdddcdb0-9152-4a09-a978-84456f9df70a"
3031
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
@@ -39,4 +40,4 @@ UnicodePlots = "b8865327-cd53-5732-bb35-84acbb429228"
3940
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
4041

4142
[targets]
42-
test = ["ChainRulesTestUtils", "AMDGPU", "CUDA", "Documenter", "FiniteDifferences", "ForwardDiff", "Logging", "NNlibCUDA", "Random", "StableRNGs", "Test", "UnicodePlots", "Zygote"]
43+
test = ["ChainRulesTestUtils", "CUDA", "Documenter", "FiniteDifferences", "ForwardDiff", "Logging", "NNlibCUDA", "Random", "StableRNGs", "Test", "UnicodePlots", "Zygote"]

docs/src/index.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,5 @@
44

55
For use with automatic differentiation, this package defines gradients using [ChainRules.jl](https://github.com/JuliaDiff/ChainRules.jl). These will be seen by various packages including [Zygote.jl](https://github.com/FluxML/Zygote.jl).
66

7-
To use these functions with [CUDA.jl](https://github.com/JuliaGPU/CUDA.jl)
8-
or [AMDGPU.jl](https://github.com/JuliaGPU/AMDGPU.jl) you will need to load them
9-
and NNlib in the same Julia session.
7+
To use these functions with [CUDA.jl](https://github.com/JuliaGPU/CUDA.jl) you will need [NNlibCUDA.jl](https://github.com/FluxML/NNlibCUDA.jl) as well.
8+
For [AMDGPU.jl](https://github.com/JuliaGPU/AMDGPU.jl) you will need to load it and NNlib in the same Julia session.

0 commit comments

Comments
 (0)