Make ClipNorm work on GPU Broadcasted #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -506,6 +507,19 @@ y2z(x) = x | |||
| y = Optimisers.subtract!(x, nothing) | |||
| @test y === x | |||
| end | |||
|
|
|||
| @testset "_norm(dx, p) works" begin | |||
There was a problem hiding this comment.
can we test the interface instead of an internal method?
There was a problem hiding this comment.
At present there are no GPU tests, and norm(::Broadcasted{..., Array}) works without error. So other tests which didn't fail before do call _norm.
There was a problem hiding this comment.
#71 was going to add some tests, but did not run into this failure. I haven't checked whether JLArray will in fact see it, but Metal's array type (apple M1) does.
ToucheSir
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127