Skip to content

Conversation

mcabbott
Copy link
Member

@mcabbott mcabbott commented Mar 7, 2022

This is simpler than the version in FluxML/Flux.jl#969, as it has no special handling for momentum, or not yet.

It's unusual in that I think it needs to be written as an update! rule, not an apply! rule.

Cc @chengchingwen who wrote the Flux PR.

@mcabbott mcabbott marked this pull request as draft March 7, 2022 15:51
@mcabbott mcabbott added the enhancement New feature or request label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant