Skip to content

Commit 3e99d75

Browse files
committed
use getindex with kwargs correctly
1 parent 7786c96 commit 3e99d75

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/lib/array.jl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,21 +100,21 @@ end
100100
Base.getindex(xs::TrackedArray, i...; kwargs...) = track(getindex, xs, i...; kwargs...)
101101

102102
@grad function getindex(xs::AbstractArray, i...; kwargs...)
103-
data(xs)[i...; kwargs...], function (Δ)
103+
getindex(data(xs), i...; kwargs...), function (Δ)
104104
Δ′ = zero(xs)
105-
Δ′[i...] = data)
106-
(nobacksies(:getindex, Δ′), map(_->nothing, i)...)
107-
end
105+
setindex!(Δ′, data(Δ), i...; kwargs...)
106+
(nobacksies(:getindex, Δ′), map(_->nothing, i)...) # TODO: put kwargs here
107+
end
108108
end
109109

110110
Base.view(x::TrackedArray, inds...; kwargs...) = track(Base.view, x, inds...; kwargs...)
111111

112112
@grad function view(x::AbstractArray, inds...; kwargs...)
113113
view(data(x), inds...; kwargs...), function (Δ)
114114
grad_output = zero(x)
115-
subgrad = view(grad_output, inds...)
115+
subgrad = view(grad_output, inds...; kwargs...)
116116
subgrad[:] = data(Δ)
117-
(nobacksies(:view, grad_output), map(_->nothing, inds)...)
117+
(nobacksies(:view, grad_output), map(_->nothing, inds)...) # TODO: put kwargs here
118118
end
119119
end
120120

0 commit comments

Comments
 (0)