refactor: make win/lose message a class constant

Author: FlysonBot

src/mastermind/players/abstract_player.py

@@ -41,21 +41,21 @@ def undo(self) -> None:
 
 
 class CodeCracker(Player, ABC):
-    def __init__(
-        self,
-        player_logic: "PlayerLogic",  # noqa: F821 # type: ignore
-        win_msg: str,
-        lose_msg: str,  # noqa: F821 # type: ignore
-    ) -> None:  # type: ignore  # noqa: F821
-        super().__init__(player_logic)
-        self._win_message = win_msg
-        self._lose_message = lose_msg
+    @property
+    @abstractmethod
+    def _WIN_MESSAGE(self) -> str:
+        pass
+
+    @property
+    @abstractmethod
+    def _LOSE_MESSAGE(self) -> str:
+        pass
 
     def win_message(self) -> None:
-        print(self._win_message.format(step=len(self.game_state)))
+        print(self._WIN_MESSAGE.format(step=len(self.game_state)))
 
     def lose_message(self) -> None:
-        print(self._lose_message.format(step=len(self.game_state)))
+        print(self._LOSE_MESSAGE.format(step=len(self.game_state)))
 
     @abstractmethod
     def obtain_guess(self) -> tuple:

src/mastermind/players/ai_player.py

@@ -21,10 +21,8 @@ def get_feedback(self, guess: tuple) -> tuple:
 
 
 class AICodeCracker(CodeCracker):
-    def __init__(self, player_logic: "PlayerLogic") -> None:  # type: ignore  # noqa: F821
-        win_message = "Congratulations! You won in {step} steps!"
-        lose_message = "Sorry, you lost. The secret code was {step}."
-        super().__init__(player_logic, win_message, lose_message)
+    _WIN_MESSAGE = "Congratulations! You won in {step} steps!"
+    _LOSE_MESSAGE = "Sorry, you lost. The secret code was {step}."
 
     def obtain_guess(self) -> tuple:
         # TODO: Implement AI solver logic to generate guess.

src/mastermind/players/human_player.py

@@ -69,10 +69,8 @@ def get_feedback(self, guess: tuple) -> tuple:
 
 
 class HumanCodeCracker(CodeCracker):
-    def __init__(self, player_logic: "PlayerLogic") -> None:  # type: ignore  # noqa: F821
-        win_message = "Congratulations! You won in {step} steps!"
-        lose_message = "Sorry, you lost. The secret code was {step}."
-        super().__init__(player_logic, win_message, lose_message)
+    _WIN_MESSAGE = "Congratulations! You won in {step} steps!"
+    _LOSE_MESSAGE = "Sorry, you lost. The secret code was {step}."
 
     def obtain_guess(self) -> Union[tuple, str]:
         valid_guess = ValidCombination(

tests/players/test_abstract_player.py

@@ -68,14 +68,12 @@ def test_undo(self, mock_get_feedback, mock_set_secret_code):
 class TestCodeCracker(unittest.TestCase):
     class ConcreteCodeCracker(CodeCracker):
         obtain_guess = lambda: None  # noqa: E731
+        _WIN_MESSAGE = "You win in {step} steps!"
+        _LOSE_MESSAGE = "You lose after {step} steps."
 
     def setUp(self):
         self.game = Game(6, 4, 10, "HvH")
-        self.win_msg = "You win in {step} steps!"
-        self.lose_msg = "You lose after {step} steps."
-        self.code_cracker = self.ConcreteCodeCracker(
-            self.game._player_logic, self.win_msg, self.lose_msg
-        )
+        self.code_cracker = self.ConcreteCodeCracker(self.game._player_logic)
 
     @patch.object(ConcreteCodeCracker, "obtain_guess")
     def test_undo(self, mock_obtain_guess):