Skip to content

Commit 826f395

Browse files
committed
mq: Correctly guard behind flag
1 parent 7709eef commit 826f395

File tree

4 files changed

+16
-2
lines changed

4 files changed

+16
-2
lines changed

app/src/main/java/org/akanework/gramophone/logic/GramophonePlaybackService.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -920,6 +920,7 @@ class GramophonePlaybackService : MediaLibraryService(), MediaSessionService.Lis
920920
endedWorkaroundPlayer!!.play()
921921
}
922922
} else {
923+
endedWorkaroundPlayer!!.setMediaItems(mediaList, mediaItemIndex, C.TIME_UNSET)
923924
endedWorkaroundPlayer!!.prepare()
924925
endedWorkaroundPlayer!!.play()
925926
}

app/src/main/java/org/akanework/gramophone/ui/components/ComposeComponentsTemp.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ import org.akanework.gramophone.logic.deleteQueue
5757
import org.akanework.gramophone.logic.getInactiveQueues
5858
import org.akanework.gramophone.logic.getQueue
5959
import org.akanework.gramophone.logic.loadQueue
60+
import org.akanework.gramophone.logic.utils.Flags.MQ_PREVIEW
6061

6162
@Composable
6263
fun MqListItem(
@@ -138,6 +139,7 @@ fun MqListItem(
138139
fun MqContent(
139140
mqState: MqState,
140141
modifier: Modifier = Modifier,
142+
mqEnabled: Boolean = false,
141143
) {
142144
val haptic = LocalHapticFeedback.current
143145

@@ -174,7 +176,7 @@ fun MqContent(
174176
)
175177
.padding(2.dp)
176178
.weight(1f)
177-
.clickable(enabled = !landscape) {
179+
.clickable(enabled = mqEnabled && !landscape) {
178180
mqState.toggleExpand()
179181
haptic.performHapticFeedback(HapticFeedbackType.ContextClick)
180182
}
@@ -188,7 +190,7 @@ fun MqContent(
188190
.padding(horizontal = 8.dp)
189191
)
190192
IconButton(
191-
enabled = !landscape,
193+
enabled = mqEnabled && !landscape,
192194
onClick = {
193195
mqState.toggleExpand()
194196
haptic.performHapticFeedback(HapticFeedbackType.ContextClick)

app/src/main/java/org/akanework/gramophone/ui/components/PlaylistQueueSheet.kt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package org.akanework.gramophone.ui.components
22

33
import android.content.Context
4+
import android.content.SharedPreferences
45
import android.os.SystemClock
56
import android.view.LayoutInflater
67
import android.view.View
@@ -41,15 +42,18 @@ import androidx.media3.common.MediaItem
4142
import androidx.media3.common.Player
4243
import androidx.media3.common.Timeline
4344
import androidx.media3.session.MediaBrowser
45+
import androidx.preference.PreferenceManager
4446
import androidx.recyclerview.widget.ItemTouchHelper
4547
import androidx.recyclerview.widget.LinearLayoutManager
4648
import com.google.android.material.bottomsheet.BottomSheetBehavior
4749
import com.google.android.material.bottomsheet.BottomSheetDialog
4850
import kotlinx.coroutines.launch
4951
import org.akanework.gramophone.R
52+
import org.akanework.gramophone.logic.getBooleanStrict
5053
import org.akanework.gramophone.logic.getQueueForUi
5154
import org.akanework.gramophone.logic.replaceAllSupport
5255
import org.akanework.gramophone.logic.ui.MyRecyclerView
56+
import org.akanework.gramophone.logic.utils.Flags
5357
import org.akanework.gramophone.logic.utils.convertDurationToTimeStamp
5458
import org.akanework.gramophone.ui.GramophoneTheme
5559
import org.akanework.gramophone.ui.MainActivity
@@ -59,6 +63,7 @@ import java.util.LinkedList
5963
class PlaylistQueueSheet(
6064
context: Context, private val activity: MainActivity
6165
) : BottomSheetDialog(context), Player.Listener {
66+
private var prefs: SharedPreferences
6267
private val instance: MediaBrowser?
6368
get() = activity.getPlayer()
6469
private val playlistAdapter: PlaylistCardAdapter
@@ -69,6 +74,9 @@ class PlaylistQueueSheet(
6974
private val mqEnabled: Boolean
7075

7176
init {
77+
prefs = PreferenceManager.getDefaultSharedPreferences(context.applicationContext)
78+
mqEnabled = Flags.MQ_PREVIEW && prefs.getBooleanStrict("mq_preview", false)
79+
7280
setContentView(R.layout.playlist_bottom_sheet)
7381
behavior.state = BottomSheetBehavior.STATE_EXPANDED
7482
val recyclerView = findViewById<MyRecyclerView>(R.id.recyclerview)!!
@@ -213,6 +221,7 @@ class PlaylistQueueSheet(
213221
0 -> {
214222
MqContent(
215223
mqState = mqState,
224+
mqEnabled = mqEnabled
216225
)
217226
}
218227

app/src/main/java/org/akanework/gramophone/ui/fragments/settings/ExperimentalSettingsFragment.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ class ExperimentalSettingsFragment : BasePreferenceFragment() {
4949
findPreference<Preference>("crash")!!.isVisible = BuildConfig.DEBUG
5050
if (!Flags.OFFLOAD)
5151
findPreference<Preference>("offload")!!.isVisible = false
52+
if (!Flags.MQ_PREVIEW)
53+
findPreference<Preference>("mq_preview")!!.isVisible = false
5254
if (BuildConfig.DEBUG)
5355
e = RuntimeException("skill issue")
5456
}

0 commit comments

Comments
 (0)