Normalize ticket statuses and fix ticket creation

- Add STATUS_NEW constant and normalize all status constants to lowercase with underscores
- Create ALL_STATUSES, STATUS_LABELS constants for centralized status management
- Add helper methods: getStatusValidationRule(), getPriorityValidationRule(), getStatusLabel(), getStatusOptions()
- Fix TicketCreate Livewire component to generate ticket numbers and use proper validation
- Update all controllers and services to use Ticket model constants instead of hardcoded strings
- Make created_by nullable to support portal-created tickets
- Add migration to normalize existing ticket status data in database
- Update blade templates to use model constants for status comparisons

Author: o-psi

app/Domains/Client/Controllers/ClientPortalController.php

@@ -10,6 +10,8 @@
 use App\Domains\Financial\Models\Invoice;
 use App\Domains\Financial\Models\Payment;
 use App\Domains\Security\Services\DigitalSignatureService;
+use App\Domains\Ticket\Models\Ticket;
+use App\Domains\Ticket\Repositories\TicketRepository;
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Log;
@@ -26,9 +28,14 @@ class ClientPortalController extends Controller
 
     protected DigitalSignatureService $signatureService;
 
-    public function __construct(DigitalSignatureService $signatureService)
-    {
+    protected TicketRepository $ticketRepository;
+
+    public function __construct(
+        DigitalSignatureService $signatureService,
+        TicketRepository $ticketRepository
+    ) {
         $this->signatureService = $signatureService;
+        $this->ticketRepository = $ticketRepository;
         $this->middleware('guest:client')->only(['showLogin', 'login']);
         $this->middleware('auth:client')->except(['showLogin', 'login']);
     }
@@ -983,16 +990,19 @@ public function storeTicket(Request $request)
                 'has_client' => $contact->client ? true : false,
             ]);
 
+            $ticketNumber = $this->ticketRepository->getNextTicketNumber($contact->company_id);
+
             $ticket = $contact->client->tickets()->create([
+                'number' => $ticketNumber,
                 'subject' => $request->subject,
                 'details' => $request->details,
                 'priority' => $request->priority,
                 'category' => $request->category,
-                'status' => 'Open',
+                'status' => Ticket::STATUS_OPEN,
                 'contact_id' => $contact->id,
                 'company_id' => $contact->company_id,
-                'source' => 'Portal',
-                'created_by' => $contact->id, // Use the contact ID who created the ticket
+                'source' => Ticket::SOURCE_PORTAL,
+                'created_by' => null, // Portal tickets don't have a user creator
             ]);
 
             \Log::info('Ticket created successfully', ['ticket_id' => $ticket->id]);

app/Domains/Ticket/Controllers/AssignmentController.php

@@ -2,10 +2,10 @@
 
 namespace App\Domains\Ticket\Controllers;
 
+use App\Domains\Core\Models\User;
 use App\Domains\Ticket\Models\Ticket;
 use App\Domains\Ticket\Models\TicketWatcher;
 use App\Http\Controllers\Controller;
-use App\Domains\Core\Models\User;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Facades\Validator;
@@ -82,8 +82,8 @@ public function index(Request $request)
             ->orderBy('name')
             ->get();
 
-        $statuses = ['new', 'open', 'in_progress', 'pending', 'resolved', 'closed'];
-        $priorities = ['Low', 'Medium', 'High', 'Critical'];
+        $statuses = Ticket::getAvailableStatuses();
+        $priorities = Ticket::getAvailablePriorities();
 
         // Get assignment statistics
         $stats = $this->getAssignmentStats();
@@ -477,8 +477,8 @@ public function getWorkloadReport(Request $request)
             return [
                 'assignee' => $assignee ? $assignee->name : 'Unassigned',
                 'total_tickets' => $tickets->count(),
-                'open_tickets' => $tickets->whereIn('status', ['new', 'open', 'in_progress'])->count(),
-                'closed_tickets' => $tickets->where('status', 'closed')->count(),
+                'open_tickets' => $tickets->whereIn('status', [Ticket::STATUS_NEW, Ticket::STATUS_OPEN, Ticket::STATUS_IN_PROGRESS])->count(),
+                'closed_tickets' => $tickets->where('status', Ticket::STATUS_CLOSED)->count(),
                 'avg_resolution_time' => $this->calculateAvgResolutionTime($tickets),
                 'priority_breakdown' => $tickets->groupBy('priority')->map->count(),
                 'status_breakdown' => $tickets->groupBy('status')->map->count(),
@@ -508,11 +508,11 @@ public function getTeamOverview(Request $request)
             ->withCount([
                 'assignedTickets',
                 'assignedTickets as open_tickets_count' => function ($q) {
-                    $q->whereIn('status', ['new', 'open', 'in_progress']);
+                    $q->whereIn('status', [Ticket::STATUS_NEW, Ticket::STATUS_OPEN, Ticket::STATUS_IN_PROGRESS]);
                 },
                 'assignedTickets as overdue_tickets_count' => function ($q) {
                     $q->where('due_date', '<', now())
-                        ->whereNotIn('status', ['closed', 'resolved']);
+                        ->whereNotIn('status', [Ticket::STATUS_CLOSED, Ticket::STATUS_RESOLVED]);
                 },
             ])
             ->get();
@@ -720,7 +720,7 @@ private function getTeamMemberIds(): array
      */
     private function calculateAvgResolutionTime($tickets)
     {
-        $resolvedTickets = $tickets->whereIn('status', ['resolved', 'closed'])
+        $resolvedTickets = $tickets->whereIn('status', [Ticket::STATUS_RESOLVED, Ticket::STATUS_CLOSED])
             ->filter(function ($ticket) {
                 return $ticket->resolved_at;
             });

app/Domains/Ticket/Controllers/CalendarController.php

@@ -2,10 +2,10 @@
 
 namespace App\Domains\Ticket\Controllers;
 
+use App\Domains\Core\Models\User;
 use App\Domains\Ticket\Models\Ticket;
 use App\Domains\Ticket\Models\TicketCalendarEvent;
 use App\Http\Controllers\Controller;
-use App\Domains\Core\Models\User;
 use Carbon\Carbon;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Validator;

app/Domains/Ticket/Controllers/PriorityQueueController.php

@@ -2,10 +2,10 @@
 
 namespace App\Domains\Ticket\Controllers;
 
+use App\Domains\Core\Models\User;
 use App\Domains\Ticket\Models\Ticket;
 use App\Domains\Ticket\Models\TicketPriorityQueue;
 use App\Http\Controllers\Controller;
-use App\Domains\Core\Models\User;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Facades\Validator;

app/Domains/Ticket/Controllers/RecurringTicketController.php

@@ -2,11 +2,11 @@
 
 namespace App\Domains\Ticket\Controllers;
 
+use App\Domains\Client\Models\Client;
+use App\Domains\Core\Models\User;
 use App\Domains\Ticket\Models\RecurringTicket;
 use App\Domains\Ticket\Models\TicketTemplate;
 use App\Http\Controllers\Controller;
-use App\Domains\Client\Models\Client;
-use App\Domains\Core\Models\User;
 use Carbon\Carbon;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Validator;

app/Domains/Ticket/Controllers/TemplateController.php

@@ -2,9 +2,9 @@
 
 namespace App\Domains\Ticket\Controllers;
 
+use App\Domains\Core\Models\User;
 use App\Domains\Ticket\Models\TicketTemplate;
 use App\Http\Controllers\Controller;
-use App\Domains\Core\Models\User;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Validator;
 use Illuminate\Validation\Rule;

app/Domains/Ticket/Controllers/TicketController.php

@@ -2,16 +2,16 @@
 
 namespace App\Domains\Ticket\Controllers;
 
+use App\Domains\Client\Models\Client;
 use App\Domains\Core\Controllers\Traits\UsesSelectedClient;
+use App\Domains\Core\Models\User;
 use App\Domains\Ticket\Models\Ticket;
 use App\Domains\Ticket\Models\TicketWatcher;
 use App\Domains\Ticket\Repositories\TicketRepository;
 use App\Domains\Ticket\Requests\UpdateTicketRequest;
 use App\Domains\Ticket\Services\TicketQueryService;
 use App\Http\Controllers\Controller;
 use App\Http\Requests\StoreTicketRequest;
-use App\Domains\Client\Models\Client;
-use App\Domains\Core\Models\User;
 use App\Traits\FiltersClientsByAssignment;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\DB;
@@ -83,8 +83,8 @@ public function create(Request $request)
             $selectedClient = null;
         }
 
-        $priorities = ['Low', 'Medium', 'High', 'Critical'];
-        $statuses = ['new', 'open', 'in_progress', 'pending', 'resolved', 'closed'];
+        $priorities = Ticket::getAvailablePriorities();
+        $statuses = Ticket::getAvailableStatuses();
 
         return view('tickets.create', compact(
             'clients', 'assignees', 'selectedClient', 'priorities', 'statuses'
@@ -108,7 +108,7 @@ public function store(StoreTicketRequest $request)
                     'subject' => $request->subject,
                     'details' => $request->details,
                     'priority' => $request->priority,
-                    'status' => $request->status ?? 'new',
+                    'status' => $request->status ?? Ticket::STATUS_NEW,
                     'assigned_to' => $request->assigned_to,
                     'created_by' => $user->id,
                     'scheduled_at' => $request->scheduled_at,
@@ -246,8 +246,8 @@ public function edit(Ticket $ticket)
             ->orderBy('name')
             ->get();
 
-        $priorities = ['Low', 'Medium', 'High', 'Critical'];
-        $statuses = ['new', 'open', 'in_progress', 'pending', 'resolved', 'closed'];
+        $priorities = Ticket::getAvailablePriorities();
+        $statuses = Ticket::getAvailableStatuses();
 
         return view('tickets.edit', compact('ticket', 'clients', 'assignees', 'priorities', 'statuses'));
     }

app/Domains/Ticket/Controllers/TicketQueueController.php

@@ -138,7 +138,7 @@ public function analytics(Request $request)
         $metrics = [
             'total_tickets' => Ticket::where('company_id', $companyId)->count(),
             'open_tickets' => Ticket::where('company_id', $companyId)
-                ->whereIn('status', ['open', 'in_progress'])->count(),
+                ->whereIn('status', [Ticket::STATUS_OPEN, Ticket::STATUS_IN_PROGRESS])->count(),
             'avg_resolution_time' => Ticket::where('company_id', $companyId)
                 ->whereNotNull('resolved_at')
                 ->selectRaw('AVG(EXTRACT(EPOCH FROM (resolved_at - created_at)) / 3600) as avg_hours')

app/Domains/Ticket/Controllers/TicketSearchController.php

@@ -2,9 +2,9 @@
 
 namespace App\Domains\Ticket\Controllers;
 
+use App\Domains\Core\Models\User;
 use App\Domains\Ticket\Models\Ticket;
 use App\Http\Controllers\Controller;
-use App\Domains\Core\Models\User;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Cache;
 
@@ -28,13 +28,13 @@ public function search(Request $request)
             $ticketsQuery->where('id', '!=', $exclude);
         }
 
-         $ticketsQuery->where(function ($q) use ($query) {
-             $q->whereRaw('CAST(number AS TEXT) LIKE ?', ["%{$query}%"])
-                 ->orWhere('subject', 'like', "%{$query}%")
-                 ->orWhereHas('client', function ($cq) use ($query) {
-                     $cq->where('name', 'like', "%{$query}%");
-                 });
-         });
+        $ticketsQuery->where(function ($q) use ($query) {
+            $q->whereRaw('CAST(number AS TEXT) LIKE ?', ["%{$query}%"])
+                ->orWhere('subject', 'like', "%{$query}%")
+                ->orWhereHas('client', function ($cq) use ($query) {
+                    $cq->where('name', 'like', "%{$query}%");
+                });
+        });
 
         $tickets = $ticketsQuery->orderBy('number', 'desc')
             ->limit(10)

app/Domains/Ticket/Controllers/TicketStatusController.php

@@ -2,13 +2,13 @@
 
 namespace App\Domains\Ticket\Controllers;
 
+use App\Domains\Core\Models\User;
 use App\Domains\Ticket\Models\Ticket;
 use App\Domains\Ticket\Models\TicketAssignment;
 use App\Domains\Ticket\Models\TicketComment;
 use App\Domains\Ticket\Models\TicketWatcher;
 use App\Domains\Ticket\Requests\AssignTicketRequest;
 use App\Http\Controllers\Controller;
-use App\Domains\Core\Models\User;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Facades\Validator;