Fix ticket billing settings 404 by registering proper Gate authorization

The TicketBillingSettings Livewire component was incorrectly using
$this->authorize() with a Policy class as second argument, which
Laravel doesn't support for non-model policies.

Changes:
- Add defineTicketBillingGates() method to AuthServiceProvider with
  proper Gate definitions for all ticket billing permissions
- Update TicketBillingSettings.php to use the new Gate names:
  - ticket-billing.view-settings
  - ticket-billing.manage-settings
  - ticket-billing.process-pending
  - ticket-billing.dry-run

This fixes the 404 error when accessing /settings/ticket-billing

Author: o-psi

app/Livewire/Settings/TicketBillingSettings.php

@@ -2,33 +2,45 @@
 
 namespace App\Livewire\Settings;
 
+use Flux\Flux;
 use Illuminate\Support\Facades\Artisan;
 use Illuminate\Support\Facades\Cache;
 use Illuminate\Support\Facades\Log;
 use Livewire\Component;
-use Flux\Flux;
 
 class TicketBillingSettings extends Component
 {
     // Configuration properties
     public bool $enabled;
+
     public bool $autoBillOnClose;
+
     public bool $autoBillOnResolve;
+
     public string $defaultStrategy;
+
     public float $minBillableHours;
+
     public float $roundHoursTo;
+
     public int $invoiceDueDays;
+
     public bool $requireApproval;
+
     public bool $skipZeroInvoices;
+
     public bool $autoSend;
+
     public int $batchSize;
 
     // Statistics
     public int $pendingTicketsCount = 0;
+
     public int $billingQueueCount = 0;
-    
+
     // Processing
     public bool $processing = false;
+
     public ?string $processingResult = null;
 
     protected $rules = [
@@ -48,8 +60,8 @@ class TicketBillingSettings extends Component
     public function mount()
     {
         // Authorization check
-        $this->authorize('viewSettings', \App\Policies\TicketBillingPolicy::class);
-        
+        $this->authorize('ticket-billing.view-settings');
+
         $this->loadConfiguration();
         $this->loadStatistics();
     }
@@ -86,16 +98,16 @@ protected function loadStatistics()
                 ->count();
         } catch (\Exception $e) {
             Log::error('Failed to load ticket billing statistics', [
-                'error' => $e->getMessage()
+                'error' => $e->getMessage(),
             ]);
         }
     }
 
     public function save()
     {
         // Authorization check
-        $this->authorize('manageSettings', \App\Policies\TicketBillingPolicy::class);
-        
+        $this->authorize('ticket-billing.manage-settings');
+
         $this->validate();
 
         try {
@@ -132,7 +144,7 @@ public function save()
         } catch (\Exception $e) {
             Flux::toast(
                 variant: 'danger',
-                text: 'Failed to save settings: ' . $e->getMessage(),
+                text: 'Failed to save settings: '.$e->getMessage(),
                 duration: 5000
             );
 
@@ -146,8 +158,8 @@ public function save()
     public function processPendingTickets($limit = null)
     {
         // Authorization check
-        $this->authorize('processPendingTickets', \App\Policies\TicketBillingPolicy::class);
-        
+        $this->authorize('ticket-billing.process-pending');
+
         $this->processing = true;
         $this->processingResult = null;
 
@@ -182,7 +194,7 @@ public function processPendingTickets($limit = null)
             $this->processingResult = 'error';
             Flux::toast(
                 variant: 'danger',
-                text: 'Error processing tickets: ' . $e->getMessage(),
+                text: 'Error processing tickets: '.$e->getMessage(),
                 duration: 5000
             );
         } finally {
@@ -193,8 +205,8 @@ public function processPendingTickets($limit = null)
     public function testDryRun()
     {
         // Authorization check
-        $this->authorize('runDryRun', \App\Policies\TicketBillingPolicy::class);
-        
+        $this->authorize('ticket-billing.dry-run');
+
         try {
             Artisan::call('billing:process-pending-tickets', [
                 '--dry-run' => true,
@@ -212,7 +224,7 @@ public function testDryRun()
         } catch (\Exception $e) {
             Flux::toast(
                 variant: 'danger',
-                text: 'Dry run failed: ' . $e->getMessage(),
+                text: 'Dry run failed: '.$e->getMessage(),
                 duration: 5000
             );
         }
@@ -222,7 +234,7 @@ protected function updateEnvFile(array $data)
     {
         $envFile = base_path('.env');
 
-        if (!file_exists($envFile)) {
+        if (! file_exists($envFile)) {
             throw new \Exception('.env file not found');
         }
 

app/Providers/AuthServiceProvider.php

@@ -39,11 +39,12 @@ class AuthServiceProvider extends ServiceProvider
         \App\Domains\Product\Models\PricingRule::class => \App\Policies\PricingRulePolicy::class,
         \App\Domains\Contract\Models\ContractTemplate::class => \App\Policies\ContractTemplatePolicy::class,
         \App\Domains\Email\Models\EmailAccount::class => \App\Policies\EmailAccountPolicy::class,
-         \App\Domains\HR\Models\EmployeeTimeEntry::class => \App\Policies\EmployeeTimeEntryPolicy::class,
-         \App\Domains\Integration\Models\RmmIntegration::class => \App\Policies\RmmIntegrationPolicy::class,
-         \App\Domains\Financial\Models\PlaidItem::class => \App\Policies\PlaidItemPolicy::class,
-         \App\Domains\Financial\Models\BankTransaction::class => \App\Policies\BankTransactionPolicy::class,
-     ];
+        \App\Domains\HR\Models\EmployeeTimeEntry::class => \App\Policies\EmployeeTimeEntryPolicy::class,
+        \App\Domains\Integration\Models\RmmIntegration::class => \App\Policies\RmmIntegrationPolicy::class,
+        \App\Domains\Financial\Models\PlaidItem::class => \App\Policies\PlaidItemPolicy::class,
+        \App\Domains\Financial\Models\BankTransaction::class => \App\Policies\BankTransactionPolicy::class,
+        \App\Domains\Client\Models\ClientDomain::class => \App\Policies\ClientDomainPolicy::class,
+    ];
 
     /**
      * Register any authentication / authorization services.
@@ -84,6 +85,9 @@ public function boot(): void
 
         // Define product management gates
         $this->defineProductGates();
+
+        // Define ticket billing gates
+        $this->defineTicketBillingGates();
     }
 
     /**
@@ -765,6 +769,80 @@ protected function defineProductGates(): void
         });
     }
 
+    /**
+     * Define ticket billing authorization gates.
+     */
+    protected function defineTicketBillingGates(): void
+    {
+        // View ticket billing settings
+        Gate::define('ticket-billing.view-settings', function (User $user) {
+            return $user->hasPermission('billing.settings.view')
+                || $user->hasPermission('billing.settings.manage')
+                || $user->isAdmin();
+        });
+
+        // Manage ticket billing settings
+        Gate::define('ticket-billing.manage-settings', function (User $user) {
+            return $user->hasPermission('billing.settings.manage')
+                || $user->isAdmin();
+        });
+
+        // Process pending tickets for billing
+        Gate::define('ticket-billing.process-pending', function (User $user) {
+            return $user->hasPermission('billing.tickets.process')
+                || $user->hasPermission('billing.settings.manage')
+                || $user->isAdmin();
+        });
+
+        // Run dry-run billing previews
+        Gate::define('ticket-billing.dry-run', function (User $user) {
+            return $user->hasPermission('billing.tickets.process')
+                || $user->hasPermission('billing.settings.view')
+                || $user->hasRole('manager')
+                || $user->isAdmin();
+        });
+
+        // Generate invoice from ticket
+        Gate::define('ticket-billing.generate-invoice', function (User $user) {
+            return $user->hasPermission('billing.tickets.generate')
+                || $user->isAdmin();
+        });
+
+        // Approve billing invoices
+        Gate::define('ticket-billing.approve-invoice', function (User $user) {
+            return $user->hasPermission('billing.tickets.approve')
+                || $user->hasRole('manager')
+                || $user->isAdmin();
+        });
+
+        // Void/cancel billing invoices
+        Gate::define('ticket-billing.void-invoice', function (User $user) {
+            return $user->hasPermission('billing.tickets.void')
+                || $user->hasRole('manager')
+                || $user->isAdmin();
+        });
+
+        // View billing reports
+        Gate::define('ticket-billing.view-reports', function (User $user) {
+            return $user->hasPermission('billing.reports.view')
+                || $user->hasRole('manager')
+                || $user->isAdmin();
+        });
+
+        // Modify billing amounts
+        Gate::define('ticket-billing.modify-amount', function (User $user) {
+            return $user->hasPermission('billing.tickets.modify')
+                || $user->isAdmin();
+        });
+
+        // View billing audit logs
+        Gate::define('ticket-billing.view-audit-logs', function (User $user) {
+            return $user->hasPermission('billing.audit.view')
+                || $user->hasRole('manager')
+                || $user->isAdmin();
+        });
+    }
+
     /**
      * Get all available permissions grouped by category.
      */