Skip to content

Commit b191d05

Browse files
committed
return 0/1 when quoting boolean values
1 parent b439bc0 commit b191d05

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/Drivers/ConnectionBase.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,9 @@ public function quote($value)
131131
if ($value === null) {
132132
return 'null';
133133
} elseif ($value === true) {
134-
return "'1'";
134+
return 1;
135135
} elseif ($value === false) {
136-
return "'0'";
136+
return 0;
137137
} elseif ($value instanceof Expression) {
138138
// Use the raw expression
139139
return $value->value();

tests/SphinxQL/ConnectionTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,10 +206,10 @@ public function testQuote()
206206
{
207207
$this->connection->connect();
208208
$this->assertEquals('null', $this->connection->quote(null));
209-
$this->assertEquals("'1'", $this->connection->quote(true));
210-
$this->assertEquals("'0'", $this->connection->quote(false));
209+
$this->assertEquals(1, $this->connection->quote(true));
210+
$this->assertEquals(0, $this->connection->quote(false));
211211
$this->assertEquals("fo'o'bar", $this->connection->quote(new Expression("fo'o'bar")));
212-
$this->assertEquals("123", $this->connection->quote(123));
212+
$this->assertEquals(123, $this->connection->quote(123));
213213
$this->assertEquals("12.3", $this->connection->quote(12.3));
214214
$this->assertEquals("'12.3'", $this->connection->quote('12.3'));
215215
$this->assertEquals("'12'", $this->connection->quote('12'));
@@ -219,7 +219,7 @@ public function testQuoteArr()
219219
{
220220
$this->connection->connect();
221221
$this->assertEquals(
222-
array('null', "'1'", "'0'", "fo'o'bar", "123", "12.3", "'12.3'", "'12'"),
222+
array('null', 1, 0, "fo'o'bar", 123, "12.3", "'12.3'", "'12'"),
223223
$this->connection->quoteArr(array(null, true, false, new Expression("fo'o'bar"), 123, 12.3, '12.3', '12'))
224224
);
225225
}

0 commit comments

Comments
 (0)