Skip to content

Commit db59ce8

Browse files
committed
rename Config.LogOut to Config.Logger, update New.
1 parent 71fddf9 commit db59ce8

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

cmd/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ func main() {
6464
checkError(err)
6565
cfg.TLSCert = cert
6666
}
67-
cfg.LogOut = os.Stdout
67+
cfg.Logger = os.Stdout
6868

6969
// start log4shell server
7070
server, err := log4shell.New(&cfg)

log4shell.go

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ import (
1717

1818
// Config contains configurations about log4shell server.
1919
type Config struct {
20-
LogOut io.Writer
20+
// Logger is used to set server logger writer.
21+
Logger io.Writer
2122

2223
// Hostname can be set IP address or domain name,
2324
// If enable AutoCert, must set domain name.
@@ -70,8 +71,8 @@ type Server struct {
7071
// New is used to create a new log4shell server.
7172
func New(cfg *Config) (*Server, error) {
7273
// check configuration
73-
if cfg.LogOut == nil {
74-
panic("log4shell: Config.LogOut can not be nil")
74+
if cfg.Logger == nil {
75+
panic("log4shell: Config.Logger can not be nil")
7576
}
7677
if cfg.Hostname == "" {
7778
return nil, errors.New("empty host name")
@@ -84,8 +85,8 @@ func New(cfg *Config) (*Server, error) {
8485
return nil, errors.Errorf("\"%s\" is not a directory", cfg.PayloadDir)
8586
}
8687

87-
// set logger
88-
logger := log.New(cfg.LogOut, "", log.LstdFlags)
88+
// set server logger
89+
logger := log.New(cfg.Logger, "", log.LstdFlags)
8990
ldapserver.Logger = logger
9091

9192
// initial tls config
@@ -146,10 +147,10 @@ func New(cfg *Config) (*Server, error) {
146147
return nil, errors.WithStack(err)
147148
}
148149
addr := net.JoinHostPort(cfg.Hostname, port)
149-
url := fmt.Sprintf("%s://%s/%s/", scheme, addr, secret)
150+
codeBase := fmt.Sprintf("%s://%s/%s/", scheme, addr, secret)
150151
ldapHandler := ldapHandler{
151-
logger: logger,
152-
url: url,
152+
logger: logger,
153+
codeBase: codeBase,
153154
}
154155
ldapRoute := ldapserver.NewRouteMux()
155156
ldapRoute.Bind(ldapHandler.handleBind)

log4shell_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import (
1717

1818
func testGenerateConfig() *Config {
1919
return &Config{
20-
LogOut: os.Stdout,
20+
Logger: os.Stdout,
2121
Hostname: "127.0.0.1",
2222
PayloadDir: "testdata",
2323
HTTPNetwork: "tcp",

0 commit comments

Comments
 (0)