Replace r.Form.Get with r.PostForm.Get to only parse Post values

Author: Forceu

internal/storage/chunking/Chunking.go

@@ -49,7 +49,7 @@ func ParseChunkInfo(r *http.Request, isApiCall bool) (ChunkInfo, error) {
 		formUuid = "uuid"
 	}
 
-	buf := r.Form.Get(formTotalSize)
+	buf := r.PostForm.Get(formTotalSize)
 	info.TotalFilesizeBytes, err = strconv.ParseInt(buf, 10, 64)
 	if err != nil {
 		return ChunkInfo{}, err
@@ -58,7 +58,7 @@ func ParseChunkInfo(r *http.Request, isApiCall bool) (ChunkInfo, error) {
 		return ChunkInfo{}, errors.New("value cannot be negative")
 	}
 
-	buf = r.Form.Get(formOffset)
+	buf = r.PostForm.Get(formOffset)
 	info.Offset, err = strconv.ParseInt(buf, 10, 64)
 	if err != nil {
 		return ChunkInfo{}, err
@@ -67,7 +67,7 @@ func ParseChunkInfo(r *http.Request, isApiCall bool) (ChunkInfo, error) {
 		return ChunkInfo{}, errors.New("value cannot be negative")
 	}
 
-	info.UUID = r.Form.Get(formUuid)
+	info.UUID = r.PostForm.Get(formUuid)
 	if len(info.UUID) < 10 {
 		return ChunkInfo{}, errors.New("invalid uuid submitted, needs to be at least 10 characters long")
 	}
@@ -87,12 +87,12 @@ func ParseFileHeader(r *http.Request) (FileHeader, error) {
 	if err != nil {
 		return FileHeader{}, err
 	}
-	name := r.Form.Get("filename")
+	name := r.PostForm.Get("filename")
 	if name == "" {
 		return FileHeader{}, errors.New("empty filename provided")
 	}
 	contentType := parseContentType(r)
-	size := r.Form.Get("filesize")
+	size := r.PostForm.Get("filesize")
 	if size == "" {
 		return FileHeader{}, errors.New("empty size provided")
 	}
@@ -111,11 +111,11 @@ func ParseFileHeader(r *http.Request) (FileHeader, error) {
 }
 
 func parseContentType(r *http.Request) string {
-	contentType := r.Form.Get("filecontenttype")
+	contentType := r.PostForm.Get("filecontenttype")
 	if contentType != "" {
 		return contentType
 	}
-	fileExt := strings.ToLower(filepath.Ext(r.Form.Get("filename")))
+	fileExt := strings.ToLower(filepath.Ext(r.PostForm.Get("filename")))
 	switch fileExt {
 	case ".jpg", ".jpeg":
 		contentType = "image/jpeg"

internal/test/TestHelper_test.go

@@ -4,14 +4,15 @@ package test
 
 import (
 	"errors"
-	"github.com/forceu/gokapi/internal/helper"
 	"io"
 	"log"
 	"net/http"
 	"net/http/httptest"
 	"os"
 	"testing"
 	"time"
+
+	"github.com/forceu/gokapi/internal/helper"
 )
 
 var (
@@ -300,13 +301,13 @@ func TestResponseBodyContains(t *testing.T) {
 
 func startTestServer() {
 	http.HandleFunc("/test", func(writer http.ResponseWriter, request *http.Request) {
-		io.WriteString(writer, "TestContent\n")
+		_, _ = io.WriteString(writer, "TestContent\n")
 		for _, cookie := range request.Cookies() {
-			io.WriteString(writer, "cookie name: "+cookie.Name+" cookie value: "+cookie.Value+"\n")
+			_, _ = io.WriteString(writer, "cookie name: "+cookie.Name+" cookie value: "+cookie.Value+"\n")
 		}
-		request.ParseForm()
-		if request.Form.Get("testPostKey") != "" {
-			io.WriteString(writer, "testPostKey: "+request.Form.Get("testPostKey")+"\n")
+		_ = request.ParseForm()
+		if request.PostForm.Get("testPostKey") != "" {
+			_, _ = io.WriteString(writer, "testPostKey: "+request.PostForm.Get("testPostKey")+"\n")
 		}
 	})
 	go func() { log.Fatal(http.ListenAndServe("127.0.0.1:9999", nil)) }()

internal/webserver/Webserver.go

@@ -335,7 +335,7 @@ func changePassword(w http.ResponseWriter, r *http.Request) {
 		var ok bool
 		var pwHash string
 
-		pw := r.Form.Get("newpw")
+		pw := r.PostForm.Get("newpw")
 		errMessage, pwHash, ok = validateNewPassword(pw, user)
 		if ok {
 			user.Password = pwHash
@@ -507,8 +507,8 @@ func showLogin(w http.ResponseWriter, r *http.Request) {
 		fmt.Println(err)
 		return
 	}
-	user := r.Form.Get("username")
-	pw := r.Form.Get("password")
+	user := r.PostForm.Get("username")
+	pw := r.PostForm.Get("password")
 	failedLogin := false
 	if pw != "" && user != "" {
 		ip := logging.GetIpAddress(r)
@@ -581,7 +581,7 @@ func showDownload(w http.ResponseWriter, r *http.Request) {
 
 	if file.PasswordHash != "" {
 		_ = r.ParseForm()
-		enteredPassword := r.Form.Get("password")
+		enteredPassword := r.PostForm.Get("password")
 		if configuration.HashPassword(enteredPassword, true) != file.PasswordHash && !isValidPwCookie(r, file) {
 			if enteredPassword != "" {
 				view.IsFailedLogin = true

internal/webserver/fileupload/FileUpload.go

@@ -108,7 +108,7 @@ func ParseFileHeader(r *http.Request) (string, chunking.FileHeader, models.Uploa
 	if err != nil {
 		return "", chunking.FileHeader{}, models.UploadParameters{}, err
 	}
-	chunkId := r.Form.Get("chunkid")
+	chunkId := r.PostForm.Get("chunkid")
 	config, err := parseConfig(r.Form)
 	if err != nil {
 		return "", chunking.FileHeader{}, models.UploadParameters{}, err