Skip to content

Commit 4154523

Browse files
committed
Fixed JS error when a user without Manage Users permission was creating a new API key, disable selection of API permissions for new keys when user does not have the required user permission
1 parent 84eb70e commit 4154523

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

internal/webserver/web/static/js/admin_ui_api.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ function addRowApi(apiKey, publicId) {
252252
title
253253
}) => {
254254
const i = document.createElement('i');
255-
const id = `perm_${perm.toLowerCase().replace('perm_', '')}_${publicId}`;
255+
const id = `${perm.toLowerCase()}_${publicId}`;
256256
i.id = id;
257257
i.className = `bi ${icon} ${granted ? 'perm-granted' : 'perm-notgranted'}`;
258258
i.title = title;
@@ -268,7 +268,12 @@ function addRowApi(apiKey, publicId) {
268268
cell.classList.add("perm-nochange");
269269
}
270270
if (!canManageUsers) {
271-
let cell = document.getElementById("perm_users_" + publicId);
271+
let cell = document.getElementById("perm_manage_users_" + publicId);
272+
cell.classList.add("perm-unavailable");
273+
cell.classList.add("perm-nochange");
274+
}
275+
if (!canViewSystemLog) {
276+
let cell = document.getElementById("perm_manage_logs_" + publicId);
272277
cell.classList.add("perm-unavailable");
273278
cell.classList.add("perm-nochange");
274279
}

0 commit comments

Comments
 (0)