Removed db.GetAllMetaDataIds()

Author: Forceu

internal/configuration/database/Database.go

@@ -189,11 +189,6 @@ func GetAllMetadata() map[string]models.File {
 	return db.GetAllMetadata()
 }
 
-// GetAllMetaDataIds returns all Ids that contain metadata
-func GetAllMetaDataIds() []string {
-	return db.GetAllMetaDataIds()
-}
-
 // GetMetaDataById returns a models.File from the ID passed or false if the id is not valid
 func GetMetaDataById(id string) (models.File, bool) {
 	return db.GetMetaDataById(id)

internal/configuration/database/Database_test.go

@@ -131,7 +131,7 @@ func TestE2E(t *testing.T) {
 	input.AvailableFiles = nil
 	runAllTypesCompareOutput(t, func() any { return GetEnd2EndInfo(3) }, input)
 	runAllTypesNoOutput(t, func() { DeleteEnd2EndInfo(3) })
-	runAllTypesCompareOutput(t, func() any { return GetEnd2EndInfo(3) }, models.E2EInfoEncrypted{AvailableFiles: nil})
+	runAllTypesCompareOutput(t, func() any { return GetEnd2EndInfo(3) }, models.E2EInfoEncrypted{})
 }
 
 func TestSessions(t *testing.T) {
@@ -208,7 +208,6 @@ func TestHotlinks(t *testing.T) {
 }
 
 func TestMetaData(t *testing.T) {
-	runAllTypesCompareOutput(t, func() any { return GetAllMetaDataIds() }, []string{})
 	runAllTypesCompareOutput(t, func() any { return GetAllMetadata() }, map[string]models.File{})
 	runAllTypesCompareTwoOutputs(t, func() (any, any) { return GetMetaDataById("testid") }, models.File{}, false)
 	file := models.File{
@@ -238,10 +237,8 @@ func TestMetaData(t *testing.T) {
 	}
 	runAllTypesNoOutput(t, func() { SaveMetaData(file) })
 	runAllTypesCompareTwoOutputs(t, func() (any, any) { return GetMetaDataById("testid") }, file, true)
-	runAllTypesCompareOutput(t, func() any { return GetAllMetaDataIds() }, []string{"testid"})
 	runAllTypesCompareOutput(t, func() any { return GetAllMetadata() }, map[string]models.File{"testid": file})
 	runAllTypesNoOutput(t, func() { DeleteMetaData("testid") })
-	runAllTypesCompareOutput(t, func() any { return GetAllMetaDataIds() }, []string{})
 	runAllTypesCompareOutput(t, func() any { return GetAllMetadata() }, map[string]models.File{})
 	runAllTypesCompareTwoOutputs(t, func() (any, any) { return GetMetaDataById("testid") }, models.File{}, false)
 

internal/configuration/database/dbabstraction/DbAbstraction.go

@@ -66,8 +66,6 @@ type Database interface {
 
 	// GetAllMetadata returns a map of all available files
 	GetAllMetadata() map[string]models.File
-	// GetAllMetaDataIds returns all Ids that contain metadata
-	GetAllMetaDataIds() []string
 	// GetMetaDataById returns a models.File from the ID passed or false if the id is not valid
 	GetMetaDataById(id string) (models.File, bool)
 	// SaveMetaData stores the metadata of a file to the disk

internal/configuration/database/provider/redis/Redis_test.go

@@ -509,19 +509,6 @@ func TestMetaData(t *testing.T) {
 	_ = dbInstance.GetAllMetadata()
 }
 
-func TestGetAllMetaDataIds(t *testing.T) {
-	instance, err := New(config)
-	test.IsNil(t, err)
-
-	ids := instance.GetAllMetaDataIds()
-	test.IsEqualString(t, ids[0], "test2")
-	test.IsEqualString(t, ids[1], "test3")
-
-	instance.Close()
-	defer test.ExpectPanic(t)
-	_ = instance.GetAllMetaDataIds()
-}
-
 func TestUsers(t *testing.T) {
 	instance, err := New(config)
 	test.IsNil(t, err)

internal/configuration/database/provider/redis/metadata.go

@@ -63,15 +63,6 @@ func unmarshalEncryptionInfo(f models.File) (models.File, error) {
 	return f, nil
 }
 
-// GetAllMetaDataIds returns all Ids that contain metadata
-func (p DatabaseProvider) GetAllMetaDataIds() []string {
-	result := make([]string, 0)
-	for _, key := range p.getAllKeysWithPrefix(prefixMetaData) {
-		result = append(result, strings.Replace(key, prefixMetaData, "", 1))
-	}
-	return result
-}
-
 // GetMetaDataById returns a models.File from the ID passed or false if the id is not valid
 func (p DatabaseProvider) GetMetaDataById(id string) (models.File, bool) {
 	result, ok := p.getHashMap(prefixMetaData + id)

internal/configuration/database/provider/sqlite/Sqlite_test.go

@@ -128,20 +128,6 @@ func TestDatabaseProvider_GetType(t *testing.T) {
 	test.IsEqualInt(t, dbInstance.GetType(), 0)
 }
 
-func TestGetAllMetaDataIds(t *testing.T) {
-	instance, err := New(config)
-	test.IsNil(t, err)
-	dbInstance = instance
-
-	ids := dbInstance.GetAllMetaDataIds()
-	test.IsEqualString(t, ids[0], "test2")
-	test.IsEqualString(t, ids[1], "test3")
-
-	dbInstance.Close()
-	defer test.ExpectPanic(t)
-	_ = dbInstance.GetAllMetaDataIds()
-}
-
 func TestHotlink(t *testing.T) {
 	instance, err := New(config)
 	test.IsNil(t, err)

internal/configuration/database/provider/sqlite/metadata.go

@@ -81,21 +81,6 @@ func (p DatabaseProvider) GetAllMetadata() map[string]models.File {
 	return result
 }
 
-// GetAllMetaDataIds returns all Ids that contain metadata
-func (p DatabaseProvider) GetAllMetaDataIds() []string {
-	keys := make([]string, 0)
-	rows, err := p.sqliteDb.Query("SELECT Id FROM FileMetaData")
-	helper.Check(err)
-	defer rows.Close()
-	for rows.Next() {
-		rowData := schemaMetaData{}
-		err = rows.Scan(&rowData.Id)
-		helper.Check(err)
-		keys = append(keys, rowData.Id)
-	}
-	return keys
-}
-
 // GetMetaDataById returns a models.File from the ID passed or false if the id is not valid
 func (p DatabaseProvider) GetMetaDataById(id string) (models.File, bool) {
 	result := models.File{}