Better error handling for failed chunks, allocateChunk also returns error if given size is too big

Author: Forceu

internal/storage/FileServing.go

@@ -165,6 +165,7 @@ func NewFileFromChunk(chunkId string, fileHeader chunking.FileHeader, userId int
 	defer file.Close()
 	err = validateChunkInfo(file, fileHeader)
 	if err != nil {
+		_ = chunking.DeleteChunk(chunkId)
 		return models.File{}, err
 	}
 

internal/storage/chunking/Chunking.go

@@ -214,6 +214,10 @@ func allocateFile(info ChunkInfo) error {
 	if FileExists(info.UUID) {
 		return nil
 	}
+	maxSizeBytes := int64(configuration.Get().MaxFileSizeMB) * 1024 * 1024
+	if info.TotalFilesizeBytes > maxSizeBytes {
+		return errors.New("declared file size exceeds the maximum allowed size")
+	}
 	enoughSpace, err := isEnoughSpace(info.TotalFilesizeBytes)
 	if err != nil {
 		return err

internal/webserver/api/Api.go

@@ -507,6 +507,7 @@ func apiChunkComplete(w http.ResponseWriter, r requestParser, user models.User)
 func doBlockingPartCompleteChunk(w http.ResponseWriter, uuid string, fileHeader chunking.FileHeader, user models.User, uploadParameters models.UploadParameters) {
 	file, err := fileupload.CompleteChunk(uuid, fileHeader, user.Id, uploadParameters)
 	if err != nil {
+		_ = chunking.DeleteChunk(uuid)
 		sendError(w, http.StatusBadRequest, errorcodes.UnspecifiedError, err.Error())
 		return
 	}

internal/webserver/api/routing.go

@@ -584,7 +584,6 @@ type paramE2eStore struct {
 func (p *paramE2eStore) ProcessParameter(r *http.Request) error {
 	const maxBodySize = 5 * 1024 * 1024 // 5MB in bytes
 	bodyReader := http.MaxBytesReader(nil, r.Body, maxBodySize)
-	defer bodyReader.Close()
 
 	type expectedInput struct {
 		Content string `json:"content"`