[-] Technical - Upgrade ESLint rules (#262)

Author: arnaudbesnier

.eslint-bin/js-list.json

@@ -1,61 +1,43 @@
-const fs = require('fs');
-const _ = require('lodash');
+const { spawn } = require('child_process');
 const simpleGit = require('simple-git')(`${__dirname}/..`);
-let filesListValid = require('./js-list.json')
-let filesListChanged = [];
 
-function addCommitedFilesToEslint(callback) {
+let listFilesModified = [];
+
+function getFilesModified(callback) {
   simpleGit.status((error, status) => {
     if (error) {
+      // eslint-disable-next-line no-console
       console.error(error);
       process.exit(-1);
     }
 
-    jsFilesListChanged = status.files
-      .map(file => (file.path.includes(' -> ')
-        ? file.path.substring(file.path.indexOf(' -> ') + 4) : file.path))
-      .filter(file => file.endsWith('.js'));
-
-    const addedFiles = _.difference(filesListChanged, filesListValid);
-
-    filesListValid = _.uniq(filesListValid.concat(filesListChanged).sort());
-
-    if (addedFiles.length !== 0) {
-      fs.writeFileSync(`${__dirname}/js-list.json`, `${JSON.stringify(filesListValid, null, 2)}\n`);
-      console.log(`[ESLint] Adding some files for CI validation:\n${addedFiles.join('\n')}`);
-    }
+    listFilesModified = status.files
+      .map((file) => file.path)
+      .filter((file) => file.endsWith('.js'));
 
     callback();
   });
 }
 
 function runEslint(callback) {
-  if (filesListChanged.length === 0) {
+  if (listFilesModified.length === 0) {
     return callback(0);
   }
 
-  console.log(`[ESLint] Validating changed files:\n${filesListChanged.join('\n')}`);
+  // eslint-disable-next-line no-console
+  console.log(`[ESLint] Validating changed files:\n${listFilesModified.join('\n')}`);
   const eslintPath = `${__dirname}/../node_modules/.bin/eslint`;
-  const spawn = require('child_process').spawn;
-  const cmd = spawn(eslintPath, filesListChanged, { stdio: 'inherit', shell: true });
+  const cmd = spawn(eslintPath, listFilesModified, { stdio: 'inherit', shell: true });
 
-  cmd.on('exit', function (code) {
-    callback(code);
-  });
+  return cmd.on('exit', (code) => callback(code));
 }
 
-addCommitedFilesToEslint((error) => {
+getFilesModified((error) => {
   if (error) {
+    // eslint-disable-next-line no-console
     console.error(error);
     process.exit(-2);
   }
 
-  simpleGit.add(`${__dirname}/js-list.json`, (error) => {
-    if (error) {
-      console.error(error);
-      process.exit(-3);
-    }
-
-    runEslint((code) => process.exit(code));
-  })
+  runEslint((code) => process.exit(code));
 });

.eslint-bin/lint-registered-files.js

@@ -1,6 +1,6 @@
 module.exports = {
   root: true,
-  'extends': [
+  extends: [
     'airbnb-base',
     'plugin:jest/all'
   ],
@@ -9,26 +9,10 @@ module.exports = {
     node: true,
   },
   rules: {
+    'implicit-arrow-linebreak': 0,
     'jest/no-hooks': 0,
-    'no-console': 0,
     'no-param-reassign': 0,
     'no-underscore-dangle': 0,
-    'prefer-destructuring': [
-      'error',
-      {
-        VariableDeclarator: {
-          array: false,
-          object: true,
-        },
-        AssignmentExpression: {
-          array: false,
-          object: false,
-        },
-      },
-      {
-        enforceForRenamedProperties: false,
-      },
-    ],
     'import/no-extraneous-dependencies': [
       'error',
       {

.eslint-bin/pre-commit-hook.js

@@ -14,5 +14,5 @@ before_install:
   - docker ps
 
 script:
-  - yarn lint:ci
+  - yarn lint
   - yarn test

.eslintrc.js

@@ -3,6 +3,8 @@
 ## [Unreleased]
 ### Changed
 - Technical - Rename `.env.example` file.
+- Technical - Upgrade ESLint rules.
+- Technical - Ensure that all files follow the ESLint rules.
 
 ## RELEASE 5.4.0 - 2019-11-29
 ### Added

.travis.yml

@@ -39,12 +39,10 @@
     "babel-preset-env": "7.0.0-beta.3",
     "babel-register": "7.0.0-beta.3",
     "dotenv": "6.2.0",
-    "eslint": "5.16.0",
-    "eslint-config-airbnb": "16.1.0",
-    "eslint-plugin-import": "2.17.2",
+    "eslint": "6.7.2",
+    "eslint-config-airbnb-base": "14.0.0",
+    "eslint-plugin-import": "2.18.2",
     "eslint-plugin-jest": "23.0.4",
-    "eslint-plugin-jsx-a11y": "6.0.2",
-    "eslint-plugin-react": "7.5.1",
     "jest": "24.9.0",
     "mongoose": "5.5.9",
     "mongoose-fixture-loader": "1.0.2",
@@ -55,8 +53,7 @@
   "scripts": {
     "build": "./node_modules/babel-cli/bin/babel.js src --out-dir dist && echo '\n\\033[0;34m[+] \\033[0;32mBuild done\\033[0m'",
     "build:watch": "onchange 'src/**/*.js' -i -- yarn build",
-    "lint": "./node_modules/eslint/bin/eslint.js test src",
-    "lint:ci": "node ./.eslint-bin/lint-registered-files.js",
+    "lint": "./node_modules/eslint/bin/eslint.js .eslint-bin scripts src test",
     "pre-commit": "node ./.eslint-bin/pre-commit-hook.js",
     "readme:update-coverage": "yarn test:coverage && node ./scripts/update-coverage.js",
     "release": "yarn build && node ./scripts/release.js",
@@ -66,4 +63,4 @@
   "pre-commit": [
     "pre-commit"
   ]
-}
+}