fix(has-many-dissociator): dissociate relationship when related record is deleted (#429)

Author: olesyakorovina

src/services/has-many-dissociator.js

@@ -14,22 +14,21 @@ function HasManyDissociator(model, association, opts, params, data) {
           if (error) { return reject(error); }
           return resolve();
         });
-      } else {
-        const updateParams = {};
-        updateParams[params.associationName] = { $in: documentIds };
-
-        model
-          .findByIdAndUpdate(params.recordId, {
-            $pull: updateParams,
-          }, {
-            new: true,
-          })
-          .lean()
-          .exec((error, record) => {
-            if (error) { return reject(error); }
-            return resolve(record);
-          });
       }
+      const updateParams = {};
+      updateParams[params.associationName] = { $in: documentIds };
+
+      model
+        .findByIdAndUpdate(params.recordId, {
+          $pull: updateParams,
+        }, {
+          new: true,
+        })
+        .lean()
+        .exec((error, record) => {
+          if (error) { return reject(error); }
+          return resolve(record);
+        });
     }));
 }
 

test/tests/services/has-many-dissociator.test.js

@@ -0,0 +1,123 @@
+import mongoose from 'mongoose';
+import loadFixture from 'mongoose-fixture-loader';
+import Interface from 'forest-express';
+import mongooseConnect from '../../utils/mongoose-connect';
+import HasManyDissociator from '../../../src/services/has-many-dissociator';
+
+describe('service > has-many-dissociator', () => {
+  let TreeModel;
+  let LumberJackModel;
+
+  beforeAll(() => {
+    Interface.Schemas = {
+      schemas: {
+        LumberJack: {
+          name: 'LumberJack',
+          fields: [
+            {
+              field: '_id',
+              type: 'ObjectId',
+            },
+            {
+              field: 'name',
+              type: 'String',
+            },
+          ],
+        },
+        Tree: {
+          name: 'Tree',
+          fields: [
+            {
+              field: '_id',
+              type: 'ObjectId',
+            },
+            {
+              field: 'name',
+              type: 'String',
+            },
+            {
+              field: 'owners',
+              type: ['ObjectId'],
+              reference: 'LumberJack._id',
+            },
+          ],
+        },
+      },
+    };
+
+    return mongooseConnect()
+      .then(() => {
+        const LumberJackSchema = new mongoose.Schema({
+          _id: { type: 'ObjectId' },
+          name: { type: String },
+        });
+        const TreeSchema = new mongoose.Schema({
+          id: { type: 'ObjectId' },
+          name: { type: String },
+          owners: {
+            type: ['ObjectId'],
+            ref: 'LumberJack',
+          },
+        });
+
+        LumberJackModel = mongoose.model('LumberJack', LumberJackSchema);
+        TreeModel = mongoose.model('Tree', TreeSchema);
+      });
+  });
+
+  afterAll(() => mongoose.connection.close());
+
+  beforeEach(() => Promise.all([
+    LumberJackModel.remove({}),
+    TreeModel.remove({}),
+    loadFixture(LumberJackModel, [
+      {
+        _id: '41224d776a326fb40f000001',
+        name: 'Kaladin',
+      },
+      {
+        _id: '41224d776a326fb40f000002',
+        name: 'Adolin Kholin',
+      },
+    ]),
+    loadFixture(TreeModel, [
+      {
+        _id: '41224d776a326fb40f000003',
+        name: 'Ashe Tree Lane',
+        owners: ['41224d776a326fb40f000001', '41224d776a326fb40f000002'],
+      },
+    ]),
+  ]));
+
+  it('should delete the document and the association with option delete=true', async () => {
+    expect.assertions(3);
+    await new HasManyDissociator(
+      TreeModel,
+      LumberJackModel,
+      {},
+      { delete: true, associationName: 'owners', recordId: '41224d776a326fb40f000003' },
+      { data: [{ id: '41224d776a326fb40f000002' }] },
+    ).perform();
+    const lumberJackDocumentsCount = await LumberJackModel.countDocuments();
+    const treeDocuments = await TreeModel.find({});
+    expect(lumberJackDocumentsCount).toStrictEqual(1);
+    expect(treeDocuments).toHaveLength(1);
+    expect(treeDocuments[0].owners).toHaveLength(1);
+  });
+
+  it('should delete the association but not the document with delete=false', async () => {
+    expect.assertions(3);
+    await new HasManyDissociator(
+      TreeModel,
+      LumberJackModel,
+      {},
+      { delete: false, associationName: 'owners', recordId: '41224d776a326fb40f000003' },
+      { data: [{ id: '41224d776a326fb40f000001' }] },
+    ).perform();
+    const lumberJackDocumentsCount = await LumberJackModel.countDocuments();
+    const treeDocuments = await TreeModel.find({});
+    expect(lumberJackDocumentsCount).toStrictEqual(2);
+    expect(treeDocuments).toHaveLength(1);
+    expect(treeDocuments[0].owners).toHaveLength(1);
+  });
+});