chore: fix CC issue

Author: Vincent Molinié

src/services/filters-parser.js

@@ -40,7 +40,7 @@ function FiltersParser(model, timezone, options) {
     return { [aggregatorOperator]: formatedConditions };
   };
 
-  this.formatCondition = async (condition) => {
+  this._ensureIsValidCondition = (condition) => {
     if (_.isEmpty(condition)) {
       throw new InvalidFiltersFormatError('Empty condition in filter');
     }
@@ -55,27 +55,35 @@ function FiltersParser(model, timezone, options) {
         || _.isUndefined(condition.value)) {
       throw new InvalidFiltersFormatError('Invalid condition format');
     }
+  };
 
-    if (this.isSmartField(modelSchema, condition.field)) {
-      const fieldFound = modelSchema.fields.find((field) => field.field === condition.field);
+  this.getSmartFieldCondition = async (condition) => {
+    const fieldFound = modelSchema.fields.find((field) => field.field === condition.field);
 
-      if (!fieldFound.filter) {
-        throw new Error(`"filter" method missing on smart field "${fieldFound.field}"`);
-      }
+    if (!fieldFound.filter) {
+      throw new Error(`"filter" method missing on smart field "${fieldFound.field}"`);
+    }
 
-      const formattedCondition = fieldFound
-        .filter({
-          where: await this.formatOperatorValue(
-            condition.field,
-            condition.operator,
-            condition.value,
-          ),
-          condition,
-        });
-      if (!formattedCondition) {
-        throw new Error(`"filter" method on smart field "${fieldFound.field}" must return a condition`);
-      }
-      return formattedCondition;
+    const formattedCondition = fieldFound
+      .filter({
+        where: await this.formatOperatorValue(
+          condition.field,
+          condition.operator,
+          condition.value,
+        ),
+        condition,
+      });
+    if (!formattedCondition) {
+      throw new Error(`"filter" method on smart field "${fieldFound.field}" must return a condition`);
+    }
+    return formattedCondition;
+  };
+
+  this.formatCondition = async (condition) => {
+    this._ensureIsValidCondition(condition);
+
+    if (this.isSmartField(modelSchema, condition.field)) {
+      return this.getSmartFieldCondition(condition);
     }
 
     const formatedField = this.formatField(condition.field);