refactor: deprecation warning on model.remove() (console flood) (#576)

Co-authored-by: Valentin Lamatte <[email protected]>

Author: romain-gilliotte

src/services/resource-remover.js

@@ -3,7 +3,7 @@ const P = require('bluebird');
 function ResourceRemover(Model, params) {
   this.perform = () =>
     new P((resolve, reject) => {
-      Model.remove({ _id: params.recordId }, (err) => {
+      Model.deleteOne({ _id: params.recordId }, (err) => {
         if (err) { return reject(err); }
         return resolve();
       });

test/tests/services/filters-parser.test.js

@@ -51,7 +51,7 @@ describe('service > filters-parser', () => {
         IslandModel = mongoose.model('Island', IslandSchema);
 
         defaultParser = new FiltersParser(IslandModel, timezone, options);
-        return IslandModel.remove({});
+        return IslandModel.deleteMany({});
       })
       .then(() =>
         loadFixture(IslandModel, [

test/tests/services/has-many-dissociator.test.js

@@ -68,8 +68,8 @@ describe('service > has-many-dissociator', () => {
   afterAll(() => mongoose.connection.close());
 
   beforeEach(() => Promise.all([
-    LumberJackModel.remove({}),
-    TreeModel.remove({}),
+    LumberJackModel.deleteMany({}),
+    TreeModel.deleteMany({}),
     loadFixture(LumberJackModel, [
       {
         _id: '41224d776a326fb40f000001',

test/tests/services/has-many-getter.test.js

@@ -84,7 +84,7 @@ describe('service > has-many-getter', () => {
 
         LumberJackModel = mongoose.model('LumberJack', LumberJackSchema);
         TreeModel = mongoose.model('Tree', TreeSchema);
-        return Promise.all([LumberJackModel.remove({}), TreeModel.remove({})]);
+        return Promise.all([LumberJackModel.deleteMany({}), TreeModel.deleteMany({})]);
       })
       .then(() => Promise.all([
         loadFixture(LumberJackModel, [

test/tests/services/query-builder.test.js

@@ -60,7 +60,7 @@ describe('service > query-builder', () => {
         LumberJackModel = mongoose.model('LumberJack', LumberJackSchema);
         TreeModel = mongoose.model('Tree', TreeSchema);
 
-        return Promise.all([LumberJackModel.remove({}), TreeModel.remove({})]);
+        return Promise.all([LumberJackModel.deleteMany({}), TreeModel.deleteMany({})]);
       })
       .then(() =>
         Promise.all([

test/tests/services/resource-remover.test.js

@@ -29,14 +29,14 @@ describe('service > resource-remover', () => {
         });
 
         IslandModel = mongoose.model('Island', IslandSchema);
-        return IslandModel.remove({});
+        return IslandModel.deleteMany({});
       });
   });
 
   afterAll(() => mongoose.connection.close());
 
   beforeEach(async () => {
-    await IslandModel.remove({});
+    await IslandModel.deleteMany({});
     await loadFixture(IslandModel, [
       { name: 'Kauai', _id: '56cb91bdc3464f14678934ca' },
       { name: 'Oahu', _id: '56cb91bdc3464f14678934cb' },

test/tests/services/resources-getter.test.js

@@ -86,7 +86,11 @@ describe('service > resources-getter', () => {
         UserModel = mongoose.model('User', UserSchema);
         FilmModel = mongoose.model('Film', FilmSchema);
 
-        return Promise.all([OrderModel.remove({}), UserModel.remove({}), FilmModel.remove({})]);
+        return Promise.all([
+          OrderModel.deleteMany({}),
+          UserModel.deleteMany({}),
+          FilmModel.deleteMany({}),
+        ]);
       })
       .then(() =>
         Promise.all([

test/tests/services/resources-remover.test.js

@@ -30,14 +30,14 @@ describe('service > resources-remover', () => {
         });
 
         IslandModel = mongoose.model('Island', IslandSchema);
-        return IslandModel.remove({});
+        return IslandModel.deleteMany({});
       });
   });
 
   afterAll(() => mongoose.connection.close());
 
   beforeEach(async () => {
-    await IslandModel.remove({});
+    await IslandModel.deleteMany({});
     await loadFixture(IslandModel, [
       { name: 'Kauai', _id: '56cb91bdc3464f14678934ca' },
       { name: 'Oahu', _id: '56cb91bdc3464f14678934cb' },