From 6fb266e6bd1242a090540b04d299f89140c58480 Mon Sep 17 00:00:00 2001 From: Felipe Santos Date: Sat, 3 Aug 2019 15:03:38 -0300 Subject: [PATCH 1/2] Fix mongoose types problem --- package.json | 3 +++ src/services/has-many-getter.js | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 77d1e5ed..d6b4492b 100644 --- a/package.json +++ b/package.json @@ -49,6 +49,9 @@ "semver": "5.6.0", "simple-git": "1.65.0" }, + "peerDependencies": { + "mongoose": ">=4.0.0" + }, "scripts": { "build": "./node_modules/babel-cli/bin/babel.js src --out-dir dist && echo '\n\\033[0;34m[+] \\033[0;32mBuild done\\033[0m'", "build:watch": "onchange 'src/**/*.js' -i -- yarn build", diff --git a/src/services/has-many-getter.js b/src/services/has-many-getter.js index d38cdfbb..2c1a30ba 100644 --- a/src/services/has-many-getter.js +++ b/src/services/has-many-getter.js @@ -1,5 +1,6 @@ const _ = require('lodash'); const P = require('bluebird'); +var mongooseTypes = require('mongoose').Types; const SearchBuilder = require('./search-builder'); const Interface = require('forest-express'); const utils = require('../utils/schema'); @@ -49,7 +50,7 @@ function HasManyGetter(model, association, opts, params) { return new P((resolve, reject) => { let id = params.recordId; if (OBJECTID_REGEXP.test(params.recordId)) { - id = opts.mongoose.Types.ObjectId(id); + id = mongooseTypes.ObjectId(id); } return model From 1955620b0f41fa8d4055afc6ad52124a112e29b9 Mon Sep 17 00:00:00 2001 From: Felipe Santos Date: Sat, 3 Aug 2019 15:06:28 -0300 Subject: [PATCH 2/2] Use const --- src/services/has-many-getter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services/has-many-getter.js b/src/services/has-many-getter.js index 2c1a30ba..150ba19d 100644 --- a/src/services/has-many-getter.js +++ b/src/services/has-many-getter.js @@ -1,6 +1,6 @@ const _ = require('lodash'); const P = require('bluebird'); -var mongooseTypes = require('mongoose').Types; +const mongooseTypes = require('mongoose').Types; const SearchBuilder = require('./search-builder'); const Interface = require('forest-express'); const utils = require('../utils/schema');