fix: prevent duplication of models from multiple ActiveRecord application classes (#566)

Author: FraDim

lib/forest_liana/bootstrapper.rb

@@ -114,14 +114,14 @@ def fetch_models
     def fetch_model(model)
       begin
         if model.abstract_class?
-          model.descendants.each { |submodel| fetch_model(submodel) }
+          model.subclasses.each { |submodel| fetch_model(submodel) }
         else
           if is_sti_parent_model?(model)
-            model.descendants.each { |submodel_sti| fetch_model(submodel_sti) }
+            model.subclasses.each { |submodel_sti| fetch_model(submodel_sti) }
           end
 
           if analyze_model?(model)
-            ForestLiana.models << model
+            ForestLiana.models << model unless ForestLiana.models.include?(model)
           end
         end
       rescue => exception
@@ -136,7 +136,7 @@ def cast_to_array value
     end
 
     def create_factories
-      ForestLiana.models.uniq.map do |model|
+      ForestLiana.models.map do |model|
         ForestLiana::SerializerFactory.new.serializer_for(model)
         ForestLiana::ControllerFactory.new.controller_for(model)
       end

spec/dummy/app/models/application_record.rb

@@ -0,0 +1,3 @@
+class ApplicationRecord < ActiveRecord::Base
+  self.abstract_class = true
+end

spec/dummy/app/models/product.rb

@@ -1,3 +1,3 @@
-class Product < ActiveRecord::Base
+class Product < ApplicationRecord
   validates :uri, presence: true, format: { with: URI::DEFAULT_PARSER.make_regexp }
 end

spec/dummy/app/models/reference.rb

@@ -1,2 +1,2 @@
-class Reference < ActiveRecord::Base
+class Reference < SubApplicationRecord
 end

spec/dummy/app/models/sub_application_record.rb

@@ -0,0 +1,3 @@
+class SubApplicationRecord < ApplicationRecord
+  self.abstract_class = true
+end

spec/lib/forest_liana/bootstrapper_spec.rb

@@ -1,5 +1,9 @@
 module ForestLiana
   describe Bootstrapper do
+    before do
+      allow(ForestLiana).to receive(:env_secret).and_return(nil)
+    end
+
     describe 'setup_forest_liana_meta' do
       it "should put statistic data related to user stack on a dedicated object" do
         expect(ForestLiana.meta[:stack])
@@ -9,6 +13,50 @@ module ForestLiana
       end
     end
 
+    describe 'models' do
+      let(:expected_models) do
+        [
+          Island,
+          Location,
+          Owner,
+          Product,
+          Reference,
+          Tree,
+          User
+        ]
+      end
+
+      it 'should populate the models correctly' do
+        ForestLiana::Bootstrapper.new
+        rails_models = [ActiveRecord::InternalMetadata, ActiveRecord::SchemaMigration]
+
+        expect(ForestLiana.models).to match_array(ForestLiana.models.uniq)
+        expect(ForestLiana.models).to match_array(expected_models + rails_models)
+      end
+
+      it 'should generate serializers for all models' do
+        factory = instance_double(ForestLiana::SerializerFactory, serializer_for: nil)
+        allow(ForestLiana::SerializerFactory).to receive(:new).and_return(factory)
+
+        ForestLiana::Bootstrapper.new
+
+        expected_models.each do |model|
+          expect(factory).to have_received(:serializer_for).with(model).once
+        end
+      end
+
+      it 'should generate controllers for all models' do
+        factory = instance_double(ForestLiana::ControllerFactory, controller_for: nil)
+        allow(ForestLiana::ControllerFactory).to receive(:new).and_return(factory)
+
+        ForestLiana::Bootstrapper.new
+
+        expected_models.each do |model|
+          expect(factory).to have_received(:controller_for).with(model).once
+        end
+      end
+    end
+
     describe 'generate_action_hooks' do
       schema = '{
         "collections": [
@@ -102,7 +150,6 @@ module ForestLiana
 
 
       it "Should return actions hooks empty for the island collection" do
-        allow(ForestLiana).to receive(:env_secret).and_return(nil)
         bootstrapper = Bootstrapper.new
         content = JSON.parse(schema)
         bootstrapper.instance_variable_set(:@collections_sent, content['collections'])