fix(authentication): add missing environment variable generation and check if caching is enabled (#epz6k0) (#431)

Co-authored-by: Arnaud Besnier <[email protected]>

Author: DrRaider

app/controllers/forest_liana/authentication_controller.rb

@@ -86,7 +86,7 @@ def authentication_callback
         render json: response_body, status: 200
 
       rescue => error
-        render json: { errors: [{ status: error.error_code || 500, detail: error.message }] },
+        render json: { errors: [{ status: error.try(:error_code) || 500, detail: error.message }] },
           status: error.status || :internal_server_error, serializer: nil
       end
     end

app/services/forest_liana/oidc_client_manager.rb

@@ -15,7 +15,7 @@ def self.get_client_for_callback_url(callback_url)
               registration_endpoint: configuration['registration_endpoint']
             })
           else
-            client_credentials['client_id'] = ForestLiana.forest_client_id
+            client_credentials = { 'client_id' => ForestLiana.forest_client_id }
           end
 
           client_data = { :client_id => client_credentials['client_id'], :issuer => configuration['issuer'] }

lib/forest_liana/bootstrapper.rb

@@ -18,6 +18,13 @@ def initialize
         ForestLiana.auth_secret = ForestLiana.auth_key
       end
 
+      unless Rails.application.config.action_controller.perform_caching || Rails.env.test? || ForestLiana.forest_client_id
+        FOREST_LOGGER.error "You need to enable caching on your environment to use Forest Admin.\n" \
+          "For a development environment, run: `rails dev:cache`\n" \
+          "Or setup a static forest_client_id by following this part of the documentation:\n" \
+          "https://docs.forestadmin.com/documentation/how-tos/maintain/upgrade-notes-rails/upgrade-to-v6#setup-a-static-clientid"
+      end
+
       fetch_models
       check_integrations_setup
       namespace_duplicated_models

lib/generators/forest_liana/install_generator.rb

@@ -5,6 +5,7 @@ class InstallGenerator < Rails::Generators::Base
     desc 'Forest Rails Liana installation generator'
 
     argument :env_secret, type: :string, required: true, desc: 'required', banner: 'env_secret'
+    argument :application_url, type: :string, required: false, desc: 'optional', banner: 'application_url', default: 'http://localhost:3000'
 
     def install
       if ForestLiana.env_secret.present?
@@ -27,35 +28,42 @@ def install
       if File.exist? 'config/secrets.yml'
         inject_into_file 'config/secrets.yml', after: "development:\n" do
           "  forest_env_secret: #{env_secret}\n" +
-          "  forest_auth_secret: #{auth_secret}\n"
+          "  forest_auth_secret: #{auth_secret}\n" +
+          "  forest_application_url: #{application_url}\n"
         end
 
         inject_into_file 'config/secrets.yml', after: "staging:\n", force: true do
           "  forest_env_secret: <%= ENV[\"FOREST_ENV_SECRET\"] %>\n" +
-          "  forest_auth_secret: <%= ENV[\"FOREST_AUTH_SECRET\"] %>\n"
+          "  forest_auth_secret: <%= ENV[\"FOREST_AUTH_SECRET\"] %>\n" +
+          "  forest_application_url: <%= ENV[\"FOREST_APPLICATION_URL\"] %>\n"
         end
 
         inject_into_file 'config/secrets.yml', after: "production:\n", force: true do
           "  forest_env_secret: <%= ENV[\"FOREST_ENV_SECRET\"] %>\n" +
-          "  forest_auth_secret: <%= ENV[\"FOREST_AUTH_SECRET\"] %>\n"
+          "  forest_auth_secret: <%= ENV[\"FOREST_AUTH_SECRET\"] %>\n" +
+          "  forest_application_url: <%= ENV[\"FOREST_APPLICATION_URL\"] %>\n"
         end
       else
         create_file 'config/secrets.yml' do
           "development:\n" +
           "  forest_env_secret: #{env_secret}\n" +
           "  forest_auth_secret: #{auth_secret}\n" +
+          "  forest_application_url: #{application_url}\n" +
           "staging:\n" +
           "  forest_env_secret: <%= ENV[\"FOREST_ENV_SECRET\"] %>\n" +
           "  forest_auth_secret: <%= ENV[\"FOREST_AUTH_SECRET\"] %>\n" +
+          "  forest_application_url: <%= ENV[\"FOREST_APPLICATION_URL\"] %>\n" +
           "production:\n" +
           "  forest_env_secret: <%= ENV[\"FOREST_ENV_SECRET\"] %>\n" +
-          "  forest_auth_secret: <%= ENV[\"FOREST_AUTH_SECRET\"] %>\n"
+          "  forest_auth_secret: <%= ENV[\"FOREST_AUTH_SECRET\"] %>\n" +
+          "  forest_application_url: <%= ENV[\"FOREST_APPLICATION_URL\"] %>\n"
         end
       end
 
       initializer 'forest_liana.rb' do
         "ForestLiana.env_secret = Rails.application.secrets.forest_env_secret" +
-        "\nForestLiana.auth_secret = Rails.application.secrets.forest_auth_secret"
+        "\nForestLiana.auth_secret = Rails.application.secrets.forest_auth_secret" +
+        "\nForestLiana.application_url = Rails.application.secrets.forest_application_url"
       end
     end
   end