feat: smart action hooks now have access to the http request (#499)

BREAKING CHANGE: record is no longer send to the hook midleware & values option on smart action is no longer supported

Author: arnaud-moncel

app/controllers/forest_liana/actions_controller.rb

@@ -10,10 +10,6 @@ def get_smart_action_hook_request
       end
     end
 
-    def values
-      render serializer: nil, json: {}, status: :ok
-    end
-
     def get_collection(collection_name)
       ForestLiana.apimap.find { |collection| collection.name.to_s == collection_name }
     end
@@ -27,22 +23,14 @@ def get_action(collection_name)
         nil
       end
     end
-    
-    def get_record
-      hook_request = get_smart_action_hook_request
-      model = ForestLiana::SchemaUtils.find_model_from_collection_name(hook_request[:collection_name])
-      record_getter = ForestLiana::ResourceGetter.new(model, {:id => hook_request[:ids][0]})
-      record_getter.perform
-      record_getter.record
-    end
 
     def get_smart_action_load_ctx(fields)
       fields = fields.map do |field|
         ForestLiana::WidgetsHelper.set_field_widget(field)
         field[:value] = nil unless field[:value]
         field
       end
-      {:record => get_record, :fields => fields}
+      {:fields => fields, :params => params}
     end
 
     def get_smart_action_change_ctx(fields, field_changed)
@@ -52,7 +40,7 @@ def get_smart_action_change_ctx(fields, field_changed)
         ForestLiana::WidgetsHelper.set_field_widget(field)
         field
       end
-      {:record => get_record,  :field_changed => found_field_changed, :fields => fields}
+      {:field_changed => found_field_changed, :fields => fields, :params => params}
     end
 
     def handle_result(result, action)

app/controllers/forest_liana/application_controller.rb

@@ -86,15 +86,6 @@ def authenticate_user_from_jwt
       end
     end
 
-    def get_smart_action_context
-      begin
-        params[:data][:attributes].values[0].to_hash.symbolize_keys
-      rescue => error
-        FOREST_LOGGER.error "Smart Action context retrieval error: #{error}"
-        {}
-      end
-    end
-
     def internal_server_error
       head :internal_server_error
     end

config/routes.rb

@@ -57,7 +57,6 @@
   delete ':collection', to: router
 
   # Smart Actions forms value
-  post 'actions/:action_name/values' => 'actions#values'
   post 'actions/:action_name/hooks/load' => 'actions#load'
   post 'actions/:action_name/hooks/change' => 'actions#change'
 end

spec/requests/actions_controller_spec.rb

@@ -10,14 +10,6 @@
   after(:each) do
     Island.destroy_all
   end
-
-  describe 'call /values' do
-    it 'should respond 200' do
-      post '/forest/actions/foo/values', {}
-      expect(response.status).to eq(200)
-      expect(response.body).to be {}
-    end
-  end
 
   describe 'hooks' do
     foo = {