fix: remove unnecessary validation logic in serializer relationships (#754)

Author: matthv

app/serializers/forest_liana/serializer_factory.rb

@@ -60,28 +60,20 @@ def self.get_serializer_name(active_record_class)
           unformatted_attr_name = serializer.unformat_name(attribute_name).to_sym
           object = nil
           is_collection = false
-          is_valid_attr = false
           if serializer.has_one_relationships.has_key?(unformatted_attr_name)
             # only added this condition
             if root_object.class.reflect_on_association(unformatted_attr_name)&.polymorphic?
               options[:context][:unoptimized] = true
             end
 
-            is_valid_attr = true
             attr_data = serializer.has_one_relationships[unformatted_attr_name]
             object = serializer.has_one_relationship(unformatted_attr_name, attr_data)
           elsif serializer.has_many_relationships.has_key?(unformatted_attr_name)
-            is_valid_attr = true
             is_collection = true
             attr_data = serializer.has_many_relationships[unformatted_attr_name]
             object = serializer.has_many_relationship(unformatted_attr_name, attr_data)
           end
 
-          if !is_valid_attr
-            raise ForestAdmin::JSONAPI::Serializer::InvalidIncludeError.new(
-              "'#{attribute_name}' is not a valid include.")
-          end
-
           if attribute_name != serializer.format_name(attribute_name)
             expected_name = serializer.format_name(attribute_name)
 

spec/requests/resources_spec.rb

@@ -167,6 +167,52 @@
       end
     end
   end
+
+  describe 'csv' do
+    it 'should return CSV with correct headers and data' do
+      params = {
+        fields: { 'Tree' => 'id,name,owner', 'owner' => 'name'},
+        page: { 'number' => '1', 'size' => '10' },
+        searchExtended: '0',
+        sort: '-id',
+        timezone: 'Europe/Paris',
+        header: 'id,name,owner',
+      }
+      get '/forest/Tree.csv', params: params, headers: headers
+
+      expect(response.status).to eq(200)
+      expect(response.headers['Content-Type']).to include('text/csv')
+      expect(response.headers['Content-Disposition']).to include('attachment')
+
+      csv_content = response.body
+      csv_lines = csv_content.split("\n")
+
+      expect(csv_lines.first).to eq(params[:header])
+      expect(csv_lines[1]).to eq('1,Lemon Tree,Michel')
+    end
+
+    it 'returns CSV with only requested fields and ignores optional relation' do
+      params = {
+        fields: { 'Tree' => 'id,name', 'owner' => 'name'},
+        page: { 'number' => '1', 'size' => '10' },
+        searchExtended: '0',
+        sort: '-id',
+        timezone: 'Europe/Paris',
+        header: 'id,name',
+      }
+      get '/forest/Tree.csv', params: params, headers: headers
+
+      expect(response.status).to eq(200)
+      expect(response.headers['Content-Type']).to include('text/csv')
+      expect(response.headers['Content-Disposition']).to include('attachment')
+
+      csv_content = response.body
+      csv_lines = csv_content.split("\n")
+
+      expect(csv_lines.first).to eq(params[:header])
+      expect(csv_lines[1]).to eq('1,Lemon Tree')
+    end
+  end
 end
 
 describe 'Requesting User resources', :type => :request  do