[-] Error Handling - Display an explicit error message if the envSecret is detected as missing or unknown during data a API request

Author: arnaudbesnier

CHANGELOG.md

@@ -1,6 +1,8 @@
 # Change Log
 
 ## [Unreleased]
+### Changed
+- Error Handling - Display an explicit error message if the envSecret is detected as missing or unknown during data a API request.
 
 ## RELEASE 3.0.0-beta.16 - 2019-03-29
 ### Fixed

app/controllers/forest_liana/base_controller.rb

@@ -20,7 +20,6 @@ def reject_unauthorized_ip
           end
         end
       rescue ForestLiana::Errors::ExpectedError => exception
-        exception.display_error
         error_data = JSONAPI::Serializer.serialize_errors([{
           status: exception.error_code,
           detail: exception.message

app/services/forest_liana/ip_whitelist.rb

@@ -15,7 +15,10 @@ def self.retrieve
           @@ip_whitelist_rules = ip_whitelist_data['rules']
           true
         else
-          raise "Cannot retrieve the data from the Forest server. Forest API returned an #{Errors::HTTPErrorHelper.format(response)}"
+          FOREST_LOGGER.error 'An error occured while retrieving your IP whitelist. Your Forest ' +
+            'env_secret seems to be missing or unknown. Can you check that you properly set your ' +
+            'Forest env_secret in the forest_liana initializer?'
+          false
         end
       rescue => exception
         FOREST_LOGGER.error 'Cannot retrieve the IP Whitelist from the Forest server.'