fix(forest-requester): don't swallow error anymore (#710)

* fix(forest-requester): don't swallow error anymore

* fix(forest-requester): don't swallow error anymore

* test: forest api requester

Author: SteveBunlon

app/services/forest_liana/forest_api_requester.rb

@@ -10,7 +10,10 @@ def self.get(route, query: nil, headers: {})
           query: query,
         }).response
       rescue
-        raise "Cannot reach Forest API at #{forest_api_url}#{route}, it seems to be down right now."
+        message = "Cannot reach Forest API at #{forest_api_url}#{route}, it seems to be down right now."
+        FOREST_LOGGER.error message
+        FOREST_REPORTER.report message
+        raise
       end
     end
 
@@ -29,7 +32,10 @@ def self.post(route, body: nil, query: nil, headers: {})
           body: body.to_json,
         }).response
       rescue
-        raise "Cannot reach Forest API at #{post_route}, it seems to be down right now."
+        message = "Cannot reach Forest API at #{post_route}, it seems to be down right now."
+        FOREST_LOGGER.error message
+        FOREST_REPORTER.report message
+        raise
       end
     end
 

spec/services/forest_liana/forest_api_requester_spec.rb

@@ -0,0 +1,44 @@
+module ForestLiana
+  describe ForestApiRequester do
+    describe 'when an error occurs' do
+      before do
+        allow(HTTParty).to receive(:get).and_raise(StandardError, 'Custom error message')
+        allow(HTTParty).to receive(:post).and_raise(StandardError, 'Custom error message')
+      end
+
+      describe 'Get' do
+        it 'should keep the original error and raise it with backtrace' do
+          err = nil
+
+          begin
+            ForestApiRequester.get('/incorrect_url')
+          rescue => error
+            err = error
+          end
+
+          expect(error)
+            .to be_instance_of(StandardError)
+            .and have_attributes(:message => 'Custom error message')
+            .and have_attributes(:backtrace => be_truthy)
+        end
+      end
+
+      describe 'Post' do
+        it 'should keep the original error and raise it with backtrace' do
+          err = nil
+
+          begin
+            ForestApiRequester.post('/incorrect_url')
+          rescue => error
+            err = error
+          end
+
+          expect(error)
+            .to be_instance_of(StandardError)
+            .and have_attributes(:message => 'Custom error message')
+            .and have_attributes(:backtrace => be_truthy)
+        end
+      end
+    end
+  end
+end