fix(hooks): smart action hooks response correctly send back serialized fields (#514)

Author: jeffladiray

app/controllers/forest_liana/actions_controller.rb

@@ -78,7 +78,9 @@ def handle_result(result, action)
           end
         end
 
-        updated_field
+        # Response of load hook is not JSONAPI serialized
+        # so we need to transform snake_case properties back to camelCase
+        updated_field.transform_keys { |key| key.to_s.camelize(:lower) }
       end
 
       render serializer: nil, json: { fields: fields }, status: :ok

app/models/forest_liana/model/action.rb

@@ -44,6 +44,12 @@ def initialize(attributes = {})
         field.delete(:isRequired)
       end
 
+      if field.key?(:isReadOnly)
+        FOREST_LOGGER.warn "DEPRECATION WARNING: isReadOnly on field \"#{field[:field]}\" is deprecated. Please use is_read_only."
+        field[:is_read_only] = !!field[:isReadOnly]
+        field.delete(:isReadOnly)
+      end
+
       field[:type] = "String" unless field.key?(:type)
       field[:default_value] = nil unless field.key?(:default_value)
       field[:enums] = nil unless field.key?(:enums)

spec/requests/actions_controller_spec.rb

@@ -154,7 +154,7 @@
       it 'should respond 200' do
         post '/forest/actions/my_action/hooks/load', params: JSON.dump(params), headers: headers
         expect(response.status).to eq(200)
-        expect(JSON.parse(response.body)).to eq({'fields' => [foo.merge({:value => nil}).stringify_keys]})
+        expect(JSON.parse(response.body)).to eq({'fields' => [foo.merge({:value => nil}).transform_keys { |key| key.to_s.camelize(:lower) }.stringify_keys]})
       end
 
       it 'should respond 500 with bad params' do
@@ -184,7 +184,8 @@
             ids: [1],
             fields: [updated_foo],
             collection_name: 'Island',
-            changed_field: 'foo'
+            changed_field: 'foo',
+            is_read_only: true
           }
         }
       }
@@ -195,6 +196,7 @@
         expected = updated_foo.clone.merge({:value => 'baz'})
         expected[:widgetEdit] = nil
         expected.delete(:widget)
+        expected = expected.transform_keys { |key| key.to_s.camelize(:lower) }
         expect(JSON.parse(response.body)).to eq({'fields' => [expected.stringify_keys]})
       end
 
@@ -230,6 +232,9 @@
         expected_foo = updated_foo.clone.merge({ :widgetEdit => nil})
         expected_foo.delete(:widget)
 
+        expected_enum = expected_enum.transform_keys { |key| key.to_s.camelize(:lower) }
+        expected_foo = expected_foo.transform_keys { |key| key.to_s.camelize(:lower) }
+
         expect(JSON.parse(response.body)).to eq({'fields' => [expected_foo.stringify_keys, expected_enum.stringify_keys]})
       end
 
@@ -253,6 +258,9 @@
         expected_foo = foo.clone.merge({ :widgetEdit => nil})
         expected_foo.delete(:widget)
 
+        expected_multiple_enum = expected_multiple_enum.transform_keys { |key| key.to_s.camelize(:lower) }
+        expected_foo = expected_foo.transform_keys { |key| key.to_s.camelize(:lower) }
+
         expect(JSON.parse(response.body)).to eq({'fields' => [expected_foo.stringify_keys, expected_multiple_enum.stringify_keys]})
       end
 
@@ -277,6 +285,9 @@
         expected_foo = foo.clone.merge({ :widgetEdit => nil})
         expected_foo.delete(:widget)
 
+        expected_multiple_enum = expected_multiple_enum.transform_keys { |key| key.to_s.camelize(:lower) }
+        expected_foo = expected_foo.transform_keys { |key| key.to_s.camelize(:lower) }
+
         expect(JSON.parse(response.body)).to eq({'fields' => [expected_foo.stringify_keys, expected_multiple_enum.stringify_keys]})
       end
     end