fix(auth): support multi-instances and remove auth's redirection (#407)

Author: DrRaider

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    forest_liana (6.0.0-beta.3)
+    forest_liana (6.0.0.pre.beta.3)
       arel-helpers
       base32
       bcrypt

app/controllers/forest_liana/authentication_controller.rb

@@ -46,7 +46,7 @@ def start_authentication
           { 'renderingId' => rendering_id },
         )
 
-        redirect_to(result['authorization_url'])
+        render json: { authorizationUrl: result['authorization_url']}, status: 200
       rescue => error
         render json: { errors: [{ status: 500, detail: error.message }] },
           status: :internal_server_error, serializer: nil

app/services/forest_liana/oidc_client_manager.rb

@@ -8,11 +8,15 @@ def self.get_client_for_callback_url(callback_url)
         if client_data.nil?
           configuration = ForestLiana::OidcConfigurationRetriever.retrieve()
 
-          client_credentials = ForestLiana::OidcDynamicClientRegistrator.register({
-            token_endpoint_auth_method: 'none',
-            redirect_uris: [callback_url],
-            registration_endpoint: configuration['registration_endpoint']
-          })
+          if ForestLiana.forest_client_id.nil?
+            client_credentials = ForestLiana::OidcDynamicClientRegistrator.register({
+              token_endpoint_auth_method: 'none',
+              redirect_uris: [callback_url],
+              registration_endpoint: configuration['registration_endpoint']
+            })
+          else
+            client_credentials['client_id'] = ForestLiana.forest_client_id
+          end
 
           client_data = { :client_id => client_credentials['client_id'], :issuer => configuration['issuer'] }
           Rails.cache.write(callback_url, client_data)

lib/forest_liana.rb

@@ -16,6 +16,7 @@ module UserSpace
 
   mattr_accessor :env_secret
   mattr_accessor :auth_secret
+  mattr_accessor :forest_client_id
   mattr_accessor :application_url
   mattr_accessor :integrations
   mattr_accessor :apimap

spec/requests/authentications_spec.rb

@@ -33,12 +33,13 @@
       }
     end
 
-    it "should respond with a 302 code" do
-      expect(response).to have_http_status(302)
+    it "should respond with a 200 code" do
+      expect(response).to have_http_status(200)
     end
 
     it "should return a valid authentication url" do
-      expect(response.headers['Location']).to eq('https://api.forestadmin.com/oidc/auth?client_id=random_id&redirect_uri=http%3A%2F%2Flocalhost%3A3000%2Fforest%2Fauthentication%2Fcallback&response_type=code&scope=openid%20email%20profile&state=%7B%22renderingId%22%3D%3E42%7D')
+      body = JSON.parse(response.body, :symbolize_names => true)
+      expect(body[:authorizationUrl]).to eq('https://api.forestadmin.com/oidc/auth?client_id=random_id&redirect_uri=http%3A%2F%2Flocalhost%3A3000%2Fforest%2Fauthentication%2Fcallback&response_type=code&scope=openid%20email%20profile&state=%7B%22renderingId%22%3D%3E42%7D')
     end
   end
 

test/services/forest_liana/resources_getter_test.rb

@@ -119,8 +119,8 @@ class ResourcesGetterTest < ActiveSupport::TestCase
       records = getter.records
       count = getter.count
 
-      assert records.count == 1
-      assert count = 1
+      assert records.count == 2
+      assert count = 2
       assert records.first.id == 4
       assert records.first.name == 'Oak'
       assert records.first.owner.name == 'Arnaud Besnier'