fix(apimap): fix generate schema with unknown action (#555)

Author: nicolasalexandre9

lib/forest_liana/bootstrapper.rb

@@ -59,8 +59,8 @@ def generate_action_hooks()
           c = get_collection(collection['name'])
           unless c.nil?
             a = get_action(c, action['name'])
-            load = !a.hooks.nil? && a.hooks.key?(:load) && a.hooks[:load].is_a?(Proc)
-            change = !a.hooks.nil? && a.hooks.key?(:change) && a.hooks[:change].is_a?(Hash) ? a.hooks[:change].keys : []
+            load = !a.nil? && !a.hooks.nil? && a.hooks.key?(:load) && a.hooks[:load].is_a?(Proc)
+            change = !a.nil? && !a.hooks.nil? && a.hooks.key?(:change) && a.hooks[:change].is_a?(Hash) ? a.hooks[:change].keys : []
             action['hooks'] = {'load' => load, 'change' => change}
           end
         end

spec/lib/forest_liana/bootstrapper_spec.rb

@@ -8,5 +8,109 @@ module ForestLiana
           .to include(:database_type)
       end
     end
+
+    describe 'generate_action_hooks' do
+      schema = '{
+        "collections": [
+          {
+            "name": "Island",
+            "name_old": "Island",
+            "icon": null,
+            "is_read_only": false,
+            "is_searchable": true,
+            "is_virtual": false,
+            "only_for_relationships": false,
+            "pagination_type": "page",
+            "fields": [
+              {
+                "field": "id",
+                "type": "Number",
+                "default_value": null,
+                "enums": null,
+                "integration": null,
+                "is_filterable": true,
+                "is_read_only": false,
+                "is_required": false,
+                "is_sortable": true,
+                "is_virtual": false,
+                "reference": null,
+                "inverse_of": null,
+                "widget": null,
+                "validations": []
+              },
+              {
+                "field": "first_name",
+                "type": "String",
+                "default_value": null,
+                "enums": null,
+                "integration": null,
+                "is_filterable": true,
+                "is_read_only": false,
+                "is_required": false,
+                "is_sortable": true,
+                "is_virtual": false,
+                "reference": null,
+                "inverse_of": null,
+                "widget": null,
+                "validations": []
+              },
+              {
+                "field": "last_name",
+                "type": "String",
+                "default_value": null,
+                "enums": null,
+                "integration": null,
+                "is_filterable": true,
+                "is_read_only": false,
+                "is_required": false,
+                "is_sortable": true,
+                "is_virtual": false,
+                "reference": null,
+                "inverse_of": null,
+                "widget": null,
+                "validations": []
+              }
+            ],
+            "segments": [],
+            "actions": [
+              {
+                "name": "foo",
+                "type": "bulk",
+                "base_url": null,
+                "endpoint": "forest/actions/mark-as-live",
+                "http_method": "POST",
+                "redirect": null,
+                "download": false,
+                "fields": [],
+                "hooks": {
+                  "load": false,
+                  "change": []
+                }
+              }
+            ]
+          }
+        ],
+        "meta": {
+          "liana": "forest-rails",
+          "liana_version": "7.6.0",
+          "stack": {
+            "database_type": "postgresql",
+            "orm_version": "7.0.2.4"
+          }
+        }
+      }'
+
+
+      it "Should return actions hooks empty for the island collection" do
+        allow(ForestLiana).to receive(:env_secret).and_return(nil)
+        bootstrapper = Bootstrapper.new
+        content = JSON.parse(schema)
+        bootstrapper.instance_variable_set(:@collections_sent, content['collections'])
+        bootstrapper.instance_variable_set(:@meta_sent, content['meta'])
+        bootstrapper.send(:generate_action_hooks)
+
+        expect(bootstrapper.instance_variable_get("@collections_sent").first['actions'].first['hooks']).to eq({"load"=>false, "change"=>[]})
+      end
+    end
   end
 end