fix(sti): remove unnecessary sti detection and always use actual model instead of parent (#579)

Author: SteveBunlon

app/services/forest_liana/schema_utils.rb

@@ -31,11 +31,7 @@ def self.find_model_from_collection_name(collection_name, logs = false)
         if model.abstract_class?
           model_found = self.find_model_from_abstract_class(model, collection_name)
         elsif ForestLiana.name_for(model) == collection_name
-          if self.sti_child?(model)
-            model_found = model
-          else
-            model_found = model.base_class
-          end
+          model_found = model
         end
 
         break if model_found
@@ -90,28 +86,5 @@ def self.habtm?(model)
     def self.is_active_type? model
       Object.const_defined?('ActiveType::Object') && model < ActiveType::Object
     end
-
-    def self.sti_child?(model)
-      begin
-        parent = model.try(:superclass)
-        return false unless parent.try(:table_name)
-
-        if ForestLiana.name_for(parent)
-          inheritance_column = parent.columns.find do |column|
-            (parent.inheritance_column && column.name == parent.inheritance_column)\
-              || column.name == 'type'
-          end
-
-          return inheritance_column.present?
-        end
-      rescue NoMethodError
-        # NOTICE: ActiveRecord::Base throw the exception "undefined method
-        # `abstract_class?' for Object:Class" when calling the existing method
-        # "table_name".
-        return false
-      end
-
-      return false
-    end
   end
 end