fix(smart-actions): reset value when not present in enums in hook response (#397)

Author: GuillaumeCisco

app/controllers/forest_liana/actions_controller.rb

@@ -53,7 +53,14 @@ def handle_result(result, formatted_fields, action)
       end
 
       # Apply result on fields (transform the object back to an array), preserve order.
-      fields = action.fields.map { |field| result[field[:field]] }
+      fields = action.fields.map do |field|
+        updated_field = result[field[:field]]
+        # Reset `value` when not present in `enums` (which means `enums` has changed).
+        if updated_field[:enums].is_a?(Array) && !updated_field[:enums].include?(updated_field[:value])
+          updated_field[:value] = nil
+        end
+        updated_field
+      end
 
       render serializer: nil, json: { fields: fields}, status: :ok
     end

spec/requests/actions_controller_spec.rb

@@ -30,6 +30,12 @@
         description: nil,
         widget: nil,
     }
+    enum = {
+        field: 'enum',
+        type: 'Enum',
+        enums: %w[a b c],
+    }
+
     action_definition = {
         name: 'my_action',
         fields: [foo],
@@ -76,11 +82,25 @@
             }
         }
     }
+    enums_action_definition = {
+      name: 'enums_action',
+      fields: [foo, enum],
+      hooks: {
+        :change => {
+          'foo' => -> (context) {
+            fields = context[:fields]
+            fields['enum'][:enums] = %w[c d e]
+            return fields
+          }
+        }
+      }
+    }
     action = ForestLiana::Model::Action.new(action_definition)
     fail_action = ForestLiana::Model::Action.new(fail_action_definition)
     cheat_action = ForestLiana::Model::Action.new(cheat_action_definition)
+    enums_action = ForestLiana::Model::Action.new(enums_action_definition)
     island = ForestLiana.apimap.find {|collection| collection.name.to_s == ForestLiana.name_for(Island)}
-    island.actions = [action, fail_action, cheat_action]
+    island.actions = [action, fail_action, cheat_action, enums_action]
 
     describe 'call /load' do
       params = {recordIds: [1], collectionName: 'Island'}
@@ -134,6 +154,16 @@
         post '/forest/actions/cheat_action/hooks/change', JSON.dump(params), 'CONTENT_TYPE' => 'application/json'
         expect(response.status).to eq(500)
       end
+
+      it 'should reset value when enums has changed' do
+        updated_enum = enum.clone.merge({:previousValue => nil, :value => 'a'}) # set value to a
+        p = {recordIds: [1], fields: [updated_foo, updated_enum], collectionName: 'Island', changedField: 'foo'}
+        post '/forest/actions/enums_action/hooks/change', JSON.dump(p), 'CONTENT_TYPE' => 'application/json'
+        expect(response.status).to eq(200)
+        expected_enum = updated_enum.clone.merge({ :enums => %w[c d e], :value => nil}).stringify_keys
+        expect(JSON.parse(response.body)).to eq({'fields' => [updated_foo.stringify_keys, expected_enum]})
+      end
+
     end
   end
 end