fix: serializer on relationships (#745)

Author: matthv

app/serializers/forest_liana/serializer_factory.rb

@@ -131,33 +131,6 @@ def relationship_related_link(attribute_name)
           ret
         end
 
-        def has_one_relationships
-          return {} if self.class.to_one_associations.nil?
-          data = {}
-          self.class.to_one_associations.each do |attribute_name, attr_data|
-            relation = object.class.reflect_on_all_associations.find { |a| a.name == attribute_name }
-
-            next if !should_include_attr?(attribute_name, attr_data)
-
-            unless relation.nil? || (relation.respond_to?(:polymorphic?) && relation.polymorphic?)
-              relation_class_name = ForestLiana.name_for(relation.klass).demodulize
-
-              if object.respond_to?(relation.foreign_key.to_sym) &&
-                @options[:fields][relation_class_name]&.size == 1 &&
-                @options[:fields][relation_class_name]&.include?(relation.klass.primary_key.to_sym)
-
-                attr_data[:attr_or_block] = proc {
-                  foreign_key_value = object.send(relation.foreign_key.to_sym)
-                  foreign_key_value.nil? ? nil : relation.klass.new(relation.klass.primary_key => foreign_key_value)
-                }
-              end
-            end
-
-            data[attribute_name] = attr_data
-          end
-          data
-        end
-
         private
 
         def intercom_integration?

spec/services/forest_liana/serializer_factory_spec.rb

@@ -5,27 +5,6 @@ module ForestLiana
       let(:island) { Island.create!(name: 'TestIsland') }
       let(:tree) { Tree.create!(name: 'TestTree', island: island, owner: user) }
 
-      it 'simulates has_one relation with only primary key' do
-        factory = described_class.new
-        serializer_class = factory.serializer_for(Tree)
-
-        serializer_class.send(:has_one, :island) { }
-
-        instance = serializer_class.new(tree, fields: {
-          'Island' => [:id],
-          'Tree' => [:island]
-        })
-
-        relationships = instance.send(:has_one_relationships)
-        expect(relationships).to have_key(:island)
-        relation_data = relationships[:island]
-        expect(relation_data[:attr_or_block]).to be_a(Proc)
-        model = relation_data[:attr_or_block].call
-
-        expect(model).to be_a(Island)
-        expect(model.id).to eq(island.id)
-      end
-
       it 'returns nil if foreign key is nil' do
         tree_without_island = Tree.create!(name: 'NoIslandTree', island_id: nil, owner: user)