feat: convert plugin to TS

zibs · zibs · commit 8682f25c9b6d · 2025-08-20T15:26:10.000-07:00
diff --git a/.gitignore b/.gitignore
@@ -43,6 +43,10 @@ node_modules/
 npm-debug.log
 yarn-error.log
 
+# TypeScript
+#
+*.tsbuildinfo
+
 # BUCK
 buck-out/
 \.buckd/
diff --git a/packages/react-native-app-auth/app.plugin.js b/packages/react-native-app-auth/app.plugin.js
@@ -1 +1 @@
-module.exports = require('./plugin');
+module.exports = require('./plugin/build');
diff --git a/packages/react-native-app-auth/package.json b/packages/react-native-app-auth/package.json
@@ -6,12 +6,17 @@
   "types": "index.d.ts",
   "scripts": {
     "test": "jest",
-    "lint": "eslint ."
+    "lint": "eslint .",
+    "build": "expo-module-scripts build plugin",
+    "clean": "expo-module-scripts clean plugin",
+    "lint:plugin": "expo-module-scripts lint plugin",
+    "test:plugin": "expo-module-scripts test plugin"
   },
   "files": [
     "android",
     "ios",
-    "plugin",
+    "plugin/build",
+    "plugin/src",
     "app.plugin.js",
     "index.d.ts",
     "react-native-app-auth.podspec"
@@ -39,11 +44,13 @@
     "react-native": ">=0.63.0"
   },
   "devDependencies": {
+    "@expo/config-plugins": "~10.1.2",
+    "@react-native/babel-preset": "0.79.2",
+    "expo-module-scripts": "^4.1.10",
     "jest": "^29.6.3",
     "react": "19.0.0",
     "react-native": "0.79.2",
-    "@expo/config-plugins": "~10.1.1",
-    "@react-native/babel-preset": "0.79.2"
+    "@types/node": "^22.0.0"
   },
   "dependencies": {
     "invariant": "2.2.4",
diff --git a/packages/react-native-app-auth/plugin/android/index.js b/packages/react-native-app-auth/plugin/android/index.js
diff --git a/packages/react-native-app-auth/plugin/ios/index.js b/packages/react-native-app-auth/plugin/ios/index.js
diff --git a/packages/react-native-app-auth/plugin/ios/info-plist.js b/packages/react-native-app-auth/plugin/ios/info-plist.js
diff --git a/packages/react-native-app-auth/plugin/src/android/app-build-gradle.ts b/packages/react-native-app-auth/plugin/src/android/app-build-gradle.ts
@@ -1,9 +1,10 @@
-const fs = require('fs');
+import * as fs from 'fs';
+import { AndroidConfig, withDangerousMod, ConfigPlugin } from '@expo/config-plugins';
+import { AppAuthProps } from '../types';
 
-const { AndroidConfig, withDangerousMod } = require('@expo/config-plugins');
 const codeModAndroid = require('@expo/config-plugins/build/android/codeMod');
 
-const withAppAuthAppBuildGradle = (rootConfig, props) =>
+export const withAppAuthAppBuildGradle: ConfigPlugin<AppAuthProps | undefined> = (rootConfig, props) =>
   withDangerousMod(rootConfig, [
     'android',
     config => {
@@ -35,6 +36,4 @@ const withAppAuthAppBuildGradle = (rootConfig, props) =>
 
       return config;
     },
-  ]);
-
-module.exports = { withAppAuthAppBuildGradle };
+  ]);
diff --git a/packages/react-native-app-auth/plugin/src/android/index.ts b/packages/react-native-app-auth/plugin/src/android/index.ts
@@ -0,0 +1 @@
+export { withAppAuthAppBuildGradle } from './app-build-gradle';
diff --git a/packages/react-native-app-auth/plugin/src/expo-version.ts b/packages/react-native-app-auth/plugin/src/expo-version.ts
@@ -1,11 +1,11 @@
+interface ExpoConfig {
+  sdkVersion?: string;
+}
+
 const EXPO_SDK_MAJOR_VERSION = 53;
 
-const isExpo53OrLater = config => {
+export const isExpo53OrLater = (config: ExpoConfig): boolean => {
   const expoSdkVersion = config.sdkVersion || '0.0.0';
   const [major] = expoSdkVersion.split('.');
   return Number.parseInt(major, 10) >= EXPO_SDK_MAJOR_VERSION;
-};
-
-module.exports = {
-  isExpo53OrLater,
-};
+};
diff --git a/packages/react-native-app-auth/plugin/src/index.ts b/packages/react-native-app-auth/plugin/src/index.ts
@@ -1,27 +1,27 @@
-const { withPlugins, createRunOncePlugin } = require('@expo/config-plugins');
-
-const packageJson = require('../package.json');
-
-const {
+import { withPlugins, createRunOncePlugin } from '@expo/config-plugins';
+import { AppAuthConfigPlugin, AppAuthProps } from './types';
+import {
   withAppAuthAppDelegate,
   withAppAuthAppDelegateHeader,
   withUrlSchemes,
   withBridgingHeader,
   withXcodeBuildSettings,
-} = require('./ios');
-const { withAppAuthAppBuildGradle } = require('./android');
+} from './ios';
+import { withAppAuthAppBuildGradle } from './android';
+
+const packageJson = require('../../package.json');
 
-const withAppAuth = (config, props) => {
+const withAppAuth: AppAuthConfigPlugin = (config, props) => {
   // Transform redirectUrls configuration to platform-specific format
-  const transformedProps = props?.redirectUrls ? {
+  const transformedProps: AppAuthProps = props?.redirectUrls ? {
     ios: {
       urlScheme: props.redirectUrls[0]?.split('://')[0], // Extract scheme from first URL
     },
     android: {
       appAuthRedirectScheme: props.redirectUrls[0]?.split('://')[0], // Extract scheme from first URL
     },
     ...props,
-  } : props;
+  } : (props || {});
 
   return withPlugins(config, [
     // iOS
@@ -36,4 +36,4 @@ const withAppAuth = (config, props) => {
   ]);
 };
 
-module.exports = createRunOncePlugin(withAppAuth, packageJson.name, packageJson.version);
+export default createRunOncePlugin(withAppAuth, packageJson.name, packageJson.version);
diff --git a/packages/react-native-app-auth/plugin/src/ios/app-delegate-header.ts b/packages/react-native-app-auth/plugin/src/ios/app-delegate-header.ts
@@ -1,13 +1,11 @@
-const fs = require('fs');
+import * as fs from 'fs';
+import { IOSConfig, withDangerousMod, ConfigPlugin } from '@expo/config-plugins';
+import { isExpo53OrLater } from '../expo-version';
+import { insertProtocolDeclaration } from './utils/insert-protocol-declaration';
 
-const { IOSConfig, withDangerousMod } = require('@expo/config-plugins');
 const codeModIOs = require('@expo/config-plugins/build/ios/codeMod');
 
-const { isExpo53OrLater } = require('../expo-version');
-
-const { insertProtocolDeclaration } = require('./utils/insert-protocol-declaration');
-
-const withAppAuthAppDelegateHeader = rootConfig => {
+export const withAppAuthAppDelegateHeader: ConfigPlugin = rootConfig => {
   if (isExpo53OrLater(rootConfig)) {
     return rootConfig;
   }
@@ -54,8 +52,4 @@ const withAppAuthAppDelegateHeader = rootConfig => {
       return config;
     },
   ]);
-};
-
-module.exports = {
-  withAppAuthAppDelegateHeader,
-};
+};
diff --git a/packages/react-native-app-auth/plugin/src/ios/app-delegate.ts b/packages/react-native-app-auth/plugin/src/ios/app-delegate.ts
@@ -1,9 +1,9 @@
-const { withAppDelegate } = require('@expo/config-plugins');
-const codeModIOs = require('@expo/config-plugins/build/ios/codeMod');
+import { withAppDelegate, ConfigPlugin } from '@expo/config-plugins';
+import { isExpo53OrLater } from '../expo-version';
 
-const { isExpo53OrLater } = require('../expo-version');
+const codeModIOs = require('@expo/config-plugins/build/ios/codeMod');
 
-const withAppDelegateSwift = rootConfig => {
+const withAppDelegateSwift: ConfigPlugin = rootConfig => {
   return withAppDelegate(rootConfig, config => {
     let { contents } = config.modResults;
 
@@ -35,7 +35,7 @@ const withAppDelegateSwift = rootConfig => {
   });
 };
 
-const withAppAuthAppDelegate = rootConfig => {
+export const withAppAuthAppDelegate: ConfigPlugin = rootConfig => {
   if (isExpo53OrLater(rootConfig)) {
     return withAppDelegateSwift(rootConfig);
   }
@@ -58,8 +58,4 @@ const withAppAuthAppDelegate = rootConfig => {
     config.modResults.contents = contents;
     return config;
   });
-};
-
-module.exports = {
-  withAppAuthAppDelegate,
-};
+};
diff --git a/packages/react-native-app-auth/plugin/src/ios/bridging-header.ts b/packages/react-native-app-auth/plugin/src/ios/bridging-header.ts
@@ -1,14 +1,17 @@
-const fs = require('fs');
-const path = require('path');
-
-const { withDangerousMod, withXcodeProject } = require('@expo/config-plugins');
-
-const { isExpo53OrLater } = require('../expo-version');
+import * as fs from 'fs';
+import * as path from 'path';
+import { withDangerousMod, withXcodeProject, ConfigPlugin } from '@expo/config-plugins';
+import { isExpo53OrLater } from '../expo-version';
 
 const BRIDGING_HEADER_NAME = 'AppDelegate+RNAppAuth.h';
 const BRIDGING_HEADER_CONTENT = '#import "RNAppAuthAuthorizationFlowManager.h"\n';
 
-const findBridgingHeader = dir => {
+interface ConfigWithBridgingHeader {
+  _createdBridgingHeader?: string;
+  [key: string]: any;
+}
+
+const findBridgingHeader = (dir: string): string | null => {
   const files = fs.readdirSync(dir);
 
   // First check current directory
@@ -31,7 +34,7 @@ const findBridgingHeader = dir => {
   return null;
 };
 
-const withBridgingHeader = rootConfig => {
+export const withBridgingHeader: ConfigPlugin = rootConfig => {
   if (!isExpo53OrLater(rootConfig)) {
     return rootConfig;
   }
@@ -44,7 +47,7 @@ const withBridgingHeader = rootConfig => {
       // Search for existing bridging header in the project and subfolders
       const existingHeaderPath = findBridgingHeader(iosPath);
       const importLine = BRIDGING_HEADER_CONTENT;
-      let headerPath;
+      let headerPath: string;
 
       if (existingHeaderPath) {
         headerPath = existingHeaderPath;
@@ -57,33 +60,28 @@ const withBridgingHeader = rootConfig => {
         // Default to new file if none found
         headerPath = path.join(iosPath, BRIDGING_HEADER_NAME);
         fs.writeFileSync(headerPath, `${importLine}\n`);
-        config._createdBridgingHeader = BRIDGING_HEADER_NAME;
+        (config as ConfigWithBridgingHeader)._createdBridgingHeader = BRIDGING_HEADER_NAME;
       }
 
       return config;
     },
   ]);
 };
 
-const withXcodeBuildSettings = rootConfig =>
+export const withXcodeBuildSettings: ConfigPlugin = rootConfig =>
   withXcodeProject(rootConfig, config => {
     const project = config.modResults;
     const target = project.getFirstTarget().uuid;
 
     const currentSetting = project.getBuildProperty('SWIFT_OBJC_BRIDGING_HEADER', target);
 
-    if (!currentSetting && config._createdBridgingHeader) {
+    if (!currentSetting && (config as ConfigWithBridgingHeader)._createdBridgingHeader) {
       project.addBuildProperty(
         'SWIFT_OBJC_BRIDGING_HEADER',
-        `$(SRCROOT)/${config._createdBridgingHeader}`,
+        `$(SRCROOT)/${(config as ConfigWithBridgingHeader)._createdBridgingHeader}`,
         target
       );
     }
 
     return config;
-  });
-
-module.exports = {
-  withBridgingHeader,
-  withXcodeBuildSettings,
-};
+  });
diff --git a/packages/react-native-app-auth/plugin/src/ios/index.ts b/packages/react-native-app-auth/plugin/src/ios/index.ts
@@ -0,0 +1,4 @@
+export { withAppAuthAppDelegateHeader } from './app-delegate-header';
+export { withAppAuthAppDelegate } from './app-delegate';
+export { withUrlSchemes } from './info-plist';
+export { withBridgingHeader, withXcodeBuildSettings } from './bridging-header';
diff --git a/packages/react-native-app-auth/plugin/src/ios/info-plist.ts b/packages/react-native-app-auth/plugin/src/ios/info-plist.ts
@@ -0,0 +1,23 @@
+import { withInfoPlist, ConfigPlugin } from '@expo/config-plugins';
+import { AppAuthProps } from '../types';
+
+export const withUrlSchemes: ConfigPlugin<AppAuthProps | undefined> = (config, props) => {
+  return withInfoPlist(config, cfg => {
+    if (!cfg.ios) {
+      cfg.ios = {};
+    }
+    if (!cfg.ios.infoPlist) {
+      cfg.ios.infoPlist = {};
+    }
+    if (!cfg.ios.infoPlist.CFBundleURLTypes) {
+      cfg.ios.infoPlist.CFBundleURLTypes = [];
+    }
+    
+    cfg.ios.infoPlist.CFBundleURLTypes.push({
+      CFBundleURLName: '$(PRODUCT_BUNDLE_IDENTIFIER)',
+      CFBundleURLSchemes: [props?.ios?.urlScheme],
+    });
+
+    return cfg;
+  });
+};
diff --git a/packages/react-native-app-auth/plugin/src/ios/utils/insert-protocol-declaration.ts b/packages/react-native-app-auth/plugin/src/ios/utils/insert-protocol-declaration.ts
@@ -1,9 +1,16 @@
-const insertProtocolDeclaration = ({
+interface InsertProtocolDeclarationParams {
+  source: string;
+  interfaceName: string;
+  protocolName: string;
+  baseClassName?: string;
+}
+
+export const insertProtocolDeclaration = ({
   source,
   interfaceName,
   protocolName,
   baseClassName = 'NSObject',
-}) => {
+}: InsertProtocolDeclarationParams): string => {
   const matchInterfaceDeclarationRegexp = new RegExp(
     `(@interface\\s+${interfaceName}\\s*:\\s*${baseClassName})(\\s*\\<(.*)\\>)?`
   );
@@ -21,8 +28,4 @@ const insertProtocolDeclaration = ({
   }
 
   return source;
-};
-
-module.exports = {
-  insertProtocolDeclaration,
-};
+};
diff --git a/packages/react-native-app-auth/plugin/src/types.ts b/packages/react-native-app-auth/plugin/src/types.ts
@@ -0,0 +1,13 @@
+import { ConfigPlugin } from '@expo/config-plugins';
+
+export interface AppAuthProps {
+  redirectUrls?: string[];
+  ios?: {
+    urlScheme?: string;
+  };
+  android?: {
+    appAuthRedirectScheme?: string;
+  };
+}
+
+export type AppAuthConfigPlugin = ConfigPlugin<AppAuthProps | undefined>;
diff --git a/packages/react-native-app-auth/plugin/tsconfig.json b/packages/react-native-app-auth/plugin/tsconfig.json
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-module.exports = require('./plugin');`
	`1`	`+module.exports = require('./plugin/build');`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+export { withAppAuthAppBuildGradle } from './app-build-gradle';`