Merge pull request #438 from FormidableLabs/fix/fix-revoke-basic-auth

Fix/fix revoke basic auth

Author: Kadi Kraman

README.md

@@ -177,7 +177,9 @@ const config = {
 };
 
 const result = await revoke(config, {
-  tokenToRevoke: `<TOKEN_TO_REVOKE>`
+  tokenToRevoke: `<TOKEN_TO_REVOKE>`,
+  includeBasicAuth: true,
+  sendClientId: true
 });
 ```
 

docs/config-examples/fitbit.md

@@ -30,6 +30,7 @@ const refreshedState = await refresh(config, {
 
 // Revoke token
 await revoke(config, {
-  tokenToRevoke: refreshedState.refreshToken
+  tokenToRevoke: refreshedState.refreshToken,
+  includeBasicAuth: true
 });
 ```

index.js

@@ -231,7 +231,7 @@ export const refresh = (
 
 export const revoke = async (
   { clientId, issuer, serviceConfiguration, clientSecret },
-  { tokenToRevoke, sendClientId = false, includeBasicAuthorization = false }
+  { tokenToRevoke, sendClientId = false, includeBasicAuth = false }
 ) => {
   invariant(tokenToRevoke, 'Please include the token to revoke');
   validateClientId(clientId);
@@ -255,8 +255,8 @@ export const revoke = async (
   const headers = {
     'Content-Type': 'application/x-www-form-urlencoded',
   };
-  if (includeBasicAuthorization) {
-    headers.Authorization = `basic ${base64.encode(`${clientId}:${clientSecret}`)}`;
+  if (includeBasicAuth) {
+    headers.Authorization = `Basic ${base64.encode(`${clientId}:${clientSecret}`)}`;
   }
   /**
     Identity Server insists on client_id being passed in the body,